3591 Edit Labels - Adding in functionality for users to edit labels in user dashboard #3760
Conversation
…osing teams and then conditionally displaying teams on leaderboard. Still need to fix two bugs, and still need to fix up In user profile (or dashboard), make it so users can create an organization #3313 and push in latest changes from that branch before I officially make PR for these changes.
…ll commit, making sure all features work (leaderboard visibility, admin team visibility, non-admin team visibility, and the new teams tab), etc.
…hould be fully working now and npm starting it works.
…y handle calls to update the status and visibility of an organization. Also made some edits to the teams table so that the look of the tabels are consistent across the admin page. Double checked, functionality still working. Also changed columns to be called "Status" and "Visibility".
…also on the admin dashboard to be edited or deleted. Now, for every label modal that pops up, there is a choice to either delete or edit the label details that is stored in the database.
…Webpage into 3591-edit-labels
aslassi777
changed the title
|
I know I said that we don't have to spend too much time on the UI design aspect, but ultimately it does just need to look better than this! The tags section in particular needs to be redone. Let's just copy from the Explore page's context menu for now. Even though we're going to be redoing it soon, the tags section is mostly going to be a change in CSS rather than structure, so no reason not to copy from there. Severity, too, should just be lifted from it. Like the end result doesn't need to look amazing because it'll still probably be in like a table form like this, but we should still copy what we have elsewhere so that it's familiar! And I'm hoping that it won't take toooo long to update, given that we're copying stuff that we already have? The whole second menu that pops up to edit the label also isn't great, but that's something that we can deal with in the future! |
|
Hi @misaugstad! Sorry, I didn't mean for this to be a PR review, more of a placeholder/progress-check for me to comeback to after break since finals are coming up. I made a note saying that this was a preliminary version and that the UI was to be changed. I just wanted to make sure I had the implementation down first and just wanted to make sure that you could see I was making progress on the task. I do agree that the UI is absolutely atrocious right now 😂 but that refinement should be easy to make (hopefully). I probably won't work much on this over break, but fixing the UI and adding translations will be the first thing I do next quarter! I agree that the UI is not prod level right now, but I'll fix that. Again, sorry about that, only meant this to be a placeholder and progress check-in, I should have clarified! I will for sure take a look at what we already have and pull inspiration from that, shouldn't take too long at all! |
|
Whoops, no worries! Sorry I didn't reread the PR and was just going based off what I thought you said yesterday! Enjoy your break!! |
|
All good @misaugstad! Going to make sure this is fixed up. Happy holidays to you! |
Resolves #3591
Added in functionality and UI to be able to edit labels in the database. This includes changing the label tags, changing the severity, and even deleting the label. Users are able to do this from their user dashboard by selecting a label, and admins are also able to do the same on both their user dashboards and admin dashboards. (Preliminary version - UI may need to be changed/improvements).
Only thing left (TODO): add translations, for the modals as well as the tag selection/displaying the tags in the modal as well.
After screenshots (no before screenshots, this is a new feature)
Things to check before submitting the PR