Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2705 sortby gallery #3499

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

2705 sortby gallery #3499

wants to merge 8 commits into from

Conversation

JeremyFreiburger
Copy link
Collaborator

@JeremyFreiburger JeremyFreiburger commented Feb 23, 2024

Resolves #2705

Adding a sort by feature the gallery page, includes 4 label properties to sort by, clear sorting feature, translated to all languages

Before/After screenshots (if applicable)
Screen Shot 2024-02-22 at 6 55 01 PM Screen Shot 2024-02-22 at 6 54 55 PM
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.

@jonfroehlich
Copy link
Member

Wow, neat! I do find this UI a bit confusing and a little messy. @misaugstad, thoughts? Maybe we can have Jiho help?

@JeremyFreiburger
Copy link
Collaborator Author

I met with Jiho to redesign the "Sort By" feature. Our thoughts are to have the buttons highlight green when we hover over them and stay green when clicked - similar to the filter by style.
Screen Shot 2024-03-14 at 5 26 53 PM

If a different design than arrow buttons is prefered, she designed these very cool mock ups.
@misaugstad you had previously mentioned that a drop down menu would be an additional click. Jiho is currently working on an issue to redesign the gallery page to no longer have a drop down menu for label types(like the photos below) and a drop down for the Sort By might be a suitable design now.

Let me know your thoughts on a redesign?

Screen Shot 2024-03-14 at 5 24 21 PM Screen Shot 2024-03-14 at 5 24 46 PM Screen Shot 2024-03-14 at 5 24 39 PM

@misaugstad
Copy link
Member

At first glance I like it!

@JeremyFreiburger
Copy link
Collaborator Author

스크린샷 2024-03-29 오전 1 53 52

Here are more of Jiho's designs. If a dropdown still does not seem like an option, I prefer the first one in this screenshot.

Here is the figma link aswell with the design on the full webpage: https://www.figma.com/file/fY7gqNfLoD0zGMh25uVKFY/Untitled?type=design&node-id=0%3A1&mode=design&t=F2zCLVQozyn40gNv-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding 'Sort By' control to Gallery
4 participants