Do not initialize in tasks the Core by default, only when requested #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ga-devfront
previously approved these changes
Feb 6, 2025
ga-devfront
reviewed
Feb 6, 2025
classes/Task/AbstractTask.php
Outdated
| $this->container->getFileLoader()->addXmlMd5File($this->container->getUpgrader()->getDestinationVersion(), $this->container->getProperty(UpgradeContainer::DOWNLOAD_PATH) . DIRECTORY_SEPARATOR . $archiveXml); | ||
| } | ||
| } | ||
| public function init(): void {} |
There was a problem hiding this comment.
I think you can change this to
Suggested change
| public function init(): void {} | |
| abstract public function init(): void; |
There was a problem hiding this comment.
By declaring the method as abstract, I will need to define it on each task even if I have nothing to call. This is not the behavior I wanted.
M0rgan01
reviewed
Feb 6, 2025
classes/Task/Update/UpdateFiles.php
Outdated
Comment on lines
199
to
204
| $archiveXml = $this->container->getUpdateConfiguration()->getLocalChannelXml(); | ||
| $this->container->getFileLoader()->addXmlMd5File( | ||
| $this->container->getUpgrader()->getDestinationVersion(), | ||
| $this->container->getProperty(UpgradeContainer::DOWNLOAD_PATH) . DIRECTORY_SEPARATOR . $archiveXml | ||
| ); | ||
|
|
There was a problem hiding this comment.
this is not only necessary for the local channel
Suggested change
| $archiveXml = $this->container->getUpdateConfiguration()->getLocalChannelXml(); | |
| $this->container->getFileLoader()->addXmlMd5File( | |
| $this->container->getUpgrader()->getDestinationVersion(), | |
| $this->container->getProperty(UpgradeContainer::DOWNLOAD_PATH) . DIRECTORY_SEPARATOR . $archiveXml | |
| ); | |
| if ($this->container->getUpdateConfiguration()->isChannelLocal()) { | |
| $archiveXml = $this->container->getUpdateConfiguration()->getLocalChannelXml(); | |
| $this->container->getFileLoader()->addXmlMd5File($this->container->getUpgrader()->getDestinationVersion(), $this->container->getProperty(UpgradeContainer::DOWNLOAD_PATH) . DIRECTORY_SEPARATOR . $archiveXml); | |
| } | |
There was a problem hiding this comment.
Forgot to commit it, indeed
Quetzacoalt91
force-pushed
the
remove-default-initialization-of-core
branch
from
e8192e3 to
30b90e9
Compare
Quetzacoalt91
force-pushed
the
remove-default-initialization-of-core
branch
from
30b90e9 to
1c7ee5d
Compare
|
M0rgan01
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initPrestaShopCore(). This PR also moves a XML initialization to a specific place instead of at the beginning of each update task.