Use clearDirectory for cache cleaner #1159
Conversation
M0rgan01
commented
Feb 5, 2025
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Use clearDirectory for cache cleaner |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | PrestaShop/PrestaShop#37979 |
| Sponsor company | - |
| How to test? | PrestaShop/PrestaShop#37979 |
|
Shall we wait for #1159 to be merged first? |
| } | ||
| } | ||
|
|
||
| return $hasDeletedItems; |
There was a problem hiding this comment.
@M0rgan01 If there is nothing to delete, shouldnt we also return true? Maybe sometimes you will call it by accident on an empty folder and wonder why it returns false when the folder is empty.
There was a problem hiding this comment.
Thank you for your feedback.
This boolean is present to indicate if elements have been deleted, for the purpose of conditioning potential logs, we could totally do without it.
To know if the process is going well, you should use a try catch.
I will add a more detailed doc.
There was a problem hiding this comment.
@M0rgan01 No worries, just a thought. :-) I understand.
M0rgan01
force-pushed
the
fix-clear-cache
branch
2 times, most recently
from
ed5ed0b to
e0c5ef4
Compare
M0rgan01
force-pushed
the
fix-clear-cache
branch
from
e0c5ef4 to
c6ecb7a
Compare
|
