Refactoring of the admin/autoupgrade directory structure #1156
Conversation
M0rgan01
force-pushed
the
download-online-dev
branch
from
084c4d6 to
8804419
Compare
|
@M0rgan01 Would it be possible to move these files into the folder of the module, or a var directory? Why I ask - we run integrity checks on our shops every night and we have to whitelist these files as they could change depending on if autoupgrade is installed, I think that the admin directory shouldn't really change. |
|
@Hlavtox We actually asked ourselves this question. We use this folder because we are forced to do so for several technical reasons, but also to remain compatible with old versions (not to force users to move their backup / local archives) but also to be able to consult the logs by a URL hidden behind the admin folder. For v7 it will stay like this but it is not excluded that it will change in the future |
classes/UpgradeContainer.php
Outdated
| const FILES_PATH = 'files'; | ||
| const FILES_DIR = 'files/'; |
There was a problem hiding this comment.
Shouldn't these constants be called
| const FILES_PATH = 'files'; | |
| const FILES_DIR = 'files/'; | |
| const TMP_FILES_PATH = 'files'; | |
| const TMP_FILES_DIR = 'files/'; |
like the 3 next ones? As they are all subdirectories of the tmp/ folder.
classes/UpgradeContainer.php
Outdated
| case self::TMP_MODULES_DIR: | ||
| return $this->getProperty(self::TMP_MODULES_PATH) . DIRECTORY_SEPARATOR; | ||
| case self::TMP_RELEASES_DIR: | ||
| return $this->getProperty(self::TMP_PATH) . DIRECTORY_SEPARATOR . 'releases' . DIRECTORY_SEPARATOR; |
There was a problem hiding this comment.
Shall we keep the consistency of having two properties for each folder?
There was a problem hiding this comment.
For me, it's a matter of need; it's not necessary for every folder to always have a constant path and another directory.
| $tmpModulePath = $this->container->getProperty(UpgradeContainer::TMP_MODULES_PATH); | ||
| if ($this->container->getFileSystem()->exists($tmpModulePath)) { | ||
| foreach (scandir($tmpModulePath) as $item) { | ||
| if ($item !== '.' && $item !== '..' && $item !== 'index.php') { |
There was a problem hiding this comment.
I've seen these checks on another place, I wonder is a helper method for this is a good addition to the project.
For a matter of practicality and history. This folder is already present when unzipping a store, even if the module is not installed. Moreover, this prevents users from having to move or lose their archives. |
M0rgan01
force-pushed
the
download-online-dev
branch
4 times, most recently
from
4924af2 to
1c7eb0f
Compare
M0rgan01
force-pushed
the
download-online-dev
branch
from
1c7eb0f to
64d96e5
Compare
|
This PR reorganizes the admin/autoupgrade directory structure to improve temporary file management and prevent accidental overwriting of local releases.
Changes introduced:
downloadfolder no longer stores the downloaded release in online mode and is no longer erased in certain scenarios, preventing the loss of locally stored releases.latestfolder, which contained the extracted destination release, has been renamed tofilesand moved totmp/.tmp/releasesfolder has been created to store the downloaded release in online mode.tmp/modulesfolder has been created to store module ZIP files and migration scripts (previously located at the root oftmp/).These changes enhance the reliability of the update process and optimize the organization of temporary files.
Directory structure before/after:
Before:
After: