Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite configuration #1155

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 4, 2025

Questions Answers
Description? Adds a bit more resiliency to the upgrade process. If a shop has backported some logic from newer versions, this will prevent the attempts of overwriting the configuration keys, if they are already in the database. I did not check, but it would either fail or insert a duplicate entry.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test?

@Hlavtox Hlavtox added this to the 7.0.0 milestone Feb 4, 2025
@Hlavtox Hlavtox force-pushed the do-not-overwrite-configuration branch from a656a86 to 654453d Compare February 4, 2025 13:57
Copy link

sonarqubecloud bot commented Feb 4, 2025

@Quetzacoalt91 Quetzacoalt91 added the enhancement Type: Improvement label Feb 6, 2025
@ga-devfront
Copy link
Contributor

ga-devfront commented Feb 6, 2025

@Hlavtox I think with new CI merged yesterday you are on error with header. Can you rebase please.

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 6, 2025

@ga-devfront Brother, what do mean by header? It can be merged, there are no conflicts. :-) (I can rebase when I get to my PC of course, no worries.)

@ga-devfront
Copy link
Contributor

@ga-devfront Brother, what do mean by header? It can be merged, there are no conflicts. :-) (I can rebase when I get to my PC of course, no worries.)

We have modified the package that manages header stamps and added it to this project. Even if there is no conflict currently it is very likely that once merged the CI that checks header stamps will end up in error because the header stamps of your PR does not exactly match the new one expected.
I remain at your entire disposal if you have other questions and thank you very much for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

5 participants