[LOG] Update some error logs to warning #1138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Jan 27, 2025
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Update some error logs to warning |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? no | |
| Fixed ticket? | - |
| Sponsor company | - |
| How to test? | No need for QA, no behavior change. |
M0rgan01
force-pushed
the
turn-some-error-logs-to-warning
branch
5 times, most recently
from
6f71f1d to
9cdefd5
Compare
ga-devfront
reviewed
Jan 28, 2025
| @@ -78,7 +78,8 @@ public function downloadModule(ModuleDownloaderContext $moduleDownloaderContext) | |||
| } | |||
|
|
|||
| if (!$downloadSuccessful) { | |||
| throw (new UpgradeException('All download attempts have failed. Check your environment and try again.'))->setSeverity(UpgradeException::SEVERITY_ERROR); | |||
| $message = $this->translator->trans('All download attempts have failed. The module tech %s has been disabled. You can try to update it manually afterwards.', [$moduleDownloaderContext->getModuleName()]); | |||
There was a problem hiding this comment.
Suggested change
| $message = $this->translator->trans('All download attempts have failed. The module tech %s has been disabled. You can try to update it manually afterwards.', [$moduleDownloaderContext->getModuleName()]); | |
| $message = $this->translator->trans('All download attempts have failed. The module %s has been disabled. You can try to update it manually afterwards.', [$moduleDownloaderContext->getModuleName()]); |
M0rgan01
force-pushed
the
turn-some-error-logs-to-warning
branch
3 times, most recently
from
d5ec0ed to
600ea97
Compare
Quetzacoalt91
previously approved these changes
Jan 29, 2025
M0rgan01
force-pushed
the
turn-some-error-logs-to-warning
branch
from
600ea97 to
f70e4c6
Compare
Quetzacoalt91
previously approved these changes
Feb 4, 2025
M0rgan01
force-pushed
the
turn-some-error-logs-to-warning
branch
from
f70e4c6 to
5332b27
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.