-
Notifications
You must be signed in to change notification settings - Fork 38
Introduce GitHub action #117
Introduce GitHub action #117
Conversation
) | ||
if [ "$ENABLE_TTY" -ne 0 ]; then | ||
options+=(-it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Action doesn't support TTY.
So on CI, -it
has to be got rid of.
Hi! thanks for the PR! It seems that there are some conflicts that cannot be resolved rising the UI. Could you have a look? |
dbde654
to
2810724
Compare
I fixed then it seems to pass all tests 🌸 |
By the way, Can I be a maintainer of this repo? Recently, I’m developing a Pokémon-related product as a hobby and I use this library. I’m a Pokémon trainer since the first series and I played Sword/Shield for over 1000 hours. Thank you. |
Hi, sorry, we don't really promote unknown people to the role of maintainer, this is for security reasons. Moreover, this is a fork of Veekun's project. We here, use it only for storing modified CSV files. I guess you are the only one using the Python engine. |
I understood. I use this library at my own risk. I wish for future developments. |
Yeahh, thanks for the contributions but I really doubt there will be any code updates other than to the CSV files :), from us. But feel free to open as many PR as you want, I'll try to review and merge everything. If you commit, we could invite you as an external collaborator for this project so at least you'll have write access. Also, I see that you are interested in the upcoming gen9. Are you planning to extract data from the games? If you do, we and Veekun would be really interested in it. |
Currently, this project doesn't have CI environments 🤕
I recommend introducing CI environment strongly.
So I added GitHub Action environment instead of Travis CI.
This action runs some situations to dump Pokémon DB.
You have to merge #113 and #116 before to pass these jobs.
Please review them all 🙏