-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jcastets/linter #317
base: main
Are you sure you want to change the base?
Jcastets/linter #317
Conversation
db5cf50
to
613597a
Compare
To recap the discussion of this morning on Discord, I'll do the following: 1/ update this PR to regroup fixes in different commits. For example, there will be one commit for |
1e6e6ec
to
95888d7
Compare
We expect to reimplement the interactive output soon.
Most of these tests will be reintroduced later, but until then, let's remove them to keep the codebase clean.
95888d7
to
d56dbc1
Compare
We should probably fix the cancel context instead, see #386.
The goal of this PR is not to fix the lint issues, but instead to add the linter to the CI to improve the quality of the future code.
We will probably need to spend some time to review what errors have been silenced and should have been handled instead.