Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: HdxOitResolveTask - fix screen size computation #3512

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

Bug fix: Have a generic way to get the screen size but keeps OpenGL code for backward compatibility with legacy code.

The screen size computation in the HdxOitResolveTask is based on some OpenGL code when the aovs are not accessible. That's problematic for cases not running with OpenGL (e.g., macOs with Metal). The change consists to add the screen size to the HdxOitResolveTaskParams structure so, the computation is not anymore needed.

Note: The original design flaw remains as it computes the render buffer size and not the screen size. In some cases it could be different. For backward compatibility the computation still returns the render buffer size and uses it as screen size.

Link to proposal (if applicable)

  • N/A

Fixes Issue(s)

  • N/A

Checklist

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10632

(This is an automated message. See here for more information.)

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants