Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdEmbree] fix for random number generation (hdEmbree-UsdLux-PR01) #3211

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[hdEmbree] fix for random number generation (hdEmbree-UsdLux-PR01) #3211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pxr/imaging/plugin/hdEmbree/renderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ HdEmbreeRenderer::_RenderTiles(HdRenderThread *renderThread,

// Create a uniform distribution for jitter calculations.
std::uniform_real_distribution<float> uniform_dist(0.0f, 1.0f);
std::function<float()> uniform_float = std::bind(uniform_dist, random);
auto uniform_float = [&random, &uniform_dist]() { return uniform_dist(random); };

// _RenderTiles gets a range of tiles; iterate through them.
for (unsigned int tile = tileStart; tile < tileEnd; ++tile) {
Expand Down Expand Up @@ -923,7 +923,7 @@ HdEmbreeRenderer::_ComputeAmbientOcclusion(GfVec3f const& position,
{
// Create a uniform random distribution for AO calculations.
std::uniform_real_distribution<float> uniform_dist(0.0f, 1.0f);
std::function<float()> uniform_float = std::bind(uniform_dist, random);
auto uniform_float = [&random, &uniform_dist]() { return uniform_dist(random); };

// 0 ambient occlusion samples means disable the ambient occlusion term.
if (_ambientOcclusionSamples < 1) {
Expand Down
Loading