72 guess_license_from_pod doesn't recognize Apache licenses #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbakerdev
force-pushed
the
72-guess_license_from_pod-doesnt-recogni
branch
from
cd20dab to
05987d7
Compare
|
@Leont addressed merge conflicts |
Leont
reviewed
Oct 13, 2021
lib/Software/LicenseUtils.pm
Outdated
| @@ -52,6 +52,10 @@ my @phrases = ( | |||
| 'has dedicated the work to the Commons' => 'CC0_1_0', | |||
| 'waiving all of his or her rights to the work worldwide under copyright law' => 'CC0_1_0', | |||
| 'has waived all copyright and related or neighboring rights to' => 'CC0_1_0', | |||
| '(?:apache)(?: |-)(?:1.1)' => "Apache_1_1", | |||
There was a problem hiding this comment.
I think only the middle (?:) is necessary here? (and two lines below)
There was a problem hiding this comment.
@Leont good call, updated
|
Applied this manually, to deal with further merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #72