Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module-Metadata: Fix UTF-8 BOM detection for non-ASCII #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khwilliamson
Copy link

No description provided.

@karenetheridge
Copy link
Member

Is there any way to test this, so someone doesn't come along later and go "well tests pass without this, so I guess it's not necessary"?

@Leont
Copy link
Member

Leont commented Dec 19, 2021

Essentially this is a constant, and hence should probably be computed in a BEGIN block?

@khwilliamson
Copy link
Author

Without this patch, it fails on z/OS EBCDIC with:

Failed test 'version for ASCII package'

at t/encoding.t line 27.

got: undef

expected: '1'

Failed test 'version for Unicode package'

at t/encoding.t line 28.

got: undef

expected: '2'

Looks like you failed 2 tests of 12.

../cpan/Module-Metadata/t/encoding.t .................................
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/12 subtests

So, I guess I'm claiming there already is a test.

@khwilliamson
Copy link
Author

BEGIN block comment is now addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants