Avoid using indirect calls #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: one test from t/tempfile.t was disabled on CI as this needs investigation.
|
Hi @karenetheridge I would appreciate your review/feedback on this PR. |
karenetheridge
added a commit
that referenced
this pull request
Sep 26, 2020
|
merged and released, thanks! |
karenetheridge
added a commit
that referenced
this pull request
Sep 26, 2020
- add AppVeyor CI
- Add PERMS options to create temp file with given file permissions
- remove remaining uses of indirect object syntax (#34, Nicolas R)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this PR is on top of #33 to check the test suite with multiple versions of Perl
view test run from https://github.com/atoomic/File-Temp/actions/runs/145455709