Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change search.cpan URLs to MetaCPAN #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion corpus/CL018_yaml.meta
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"perl_5"
],
"meta-spec" : {
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec",
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec",
"version" : "2"
},
"name" : "Compiler-Lexer",
Expand Down
2 changes: 1 addition & 1 deletion lib/CPAN/Meta/Converter.pm
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ sub _dclone {
}

my %known_specs = (
'2' => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
'2' => 'https://metacpan.org/pod/CPAN::Meta::Spec',
'1.4' => 'http://module-build.sourceforge.net/META-spec-v1.4.html',
'1.3' => 'http://module-build.sourceforge.net/META-spec-v1.3.html',
'1.2' => 'http://module-build.sourceforge.net/META-spec-v1.2.html',
Expand Down
4 changes: 2 additions & 2 deletions lib/CPAN/Meta/Spec.pm
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ Example:

'meta-spec' => {
version => '2',
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause breakage in merging? Should this be handled specifically in CPAN::Meta::Merge?

url => 'https://metacpan.org/pod/CPAN::Meta::Spec',
}

(Spec 1.2) [required] {Map}
Expand Down Expand Up @@ -391,7 +391,7 @@ For the version 2 spec, either of these are recommended:

=for :list
* C<https://metacpan.org/pod/CPAN::Meta::Spec>
* C<http://search.cpan.org/perldoc?CPAN::Meta::Spec>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is silly, even if it's corrected later in the PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did a replace and didn't notice that at my first review, hence the later fix.

* C<https://metacpan.org/pod/CPAN::Meta::Spec>

=back

Expand Down
2 changes: 1 addition & 1 deletion t/converter-fragments.t
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ delete $ENV{CPAN_META_JSON_DECODER};

my $spec2 = {
version => '2',
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
url => 'https://metacpan.org/pod/CPAN::Meta::Spec',
};

my @cases = (
Expand Down
2 changes: 1 addition & 1 deletion t/data-fail/META-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"name" : "Module-Build",
"dynamic_config" : 1,
Expand Down
2 changes: 1 addition & 1 deletion t/data-fixable/META-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"version" : "0.36",
"name" : "Module-Build",
Expand Down
2 changes: 1 addition & 1 deletion t/data-fixable/invalid-meta-spec-version.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "99",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"version" : "0.36",
"name" : "Module-Build",
Expand Down
2 changes: 1 addition & 1 deletion t/data-fixable/meta-spec-version-trailing-zeros.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2.0",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"version" : "0.36",
"name" : "Module-Build",
Expand Down
2 changes: 1 addition & 1 deletion t/data-fixable/restrictive-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"version" : "0.36",
"name" : "Module-Build",
Expand Down
2 changes: 1 addition & 1 deletion t/data-fixable/version-ranges-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"abstract" : "stuff",
"version" : "0.36",
Expand Down
2 changes: 1 addition & 1 deletion t/data-test/META-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"version" : "0.36",
"name" : "Module-Build",
Expand Down
2 changes: 1 addition & 1 deletion t/data-test/provides-version-missing.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"version" : "0.36",
"name" : "Module-Build",
Expand Down
2 changes: 1 addition & 1 deletion t/data-test/restricted-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"version" : "0.36",
"name" : "Module-Build",
Expand Down
2 changes: 1 addition & 1 deletion t/data-test/version-not-normal.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"abstract" : "stuff",
"version" : "0.36",
Expand Down
2 changes: 1 addition & 1 deletion t/data-test/version-ranges-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"generated_by" : "Module::Build version 0.36",
"meta-spec" : {
"version" : "2",
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec"
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec"
},
"abstract" : "stuff",
"version" : "0.36",
Expand Down
2 changes: 1 addition & 1 deletion t/data-test/x_deprecated-META.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"perl_5"
],
"meta-spec" : {
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec",
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec",
"version" : 2
},
"name" : "Dist-Zilla-Plugin-Test-EOL",
Expand Down
2 changes: 1 addition & 1 deletion t/data-valid/META-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"perl_5"
],
"meta-spec" : {
"url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec",
"url" : "https://metacpan.org/pod/CPAN::Meta::Spec",
"version" : "2"
},
"name" : "Module-Build",
Expand Down
6 changes: 3 additions & 3 deletions t/merge.t
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ my %base = (
},
},
'meta-spec' => {
url => "http://search.cpan.org/perldoc?CPAN::Meta::Spec",
url => "https://metacpan.org/pod/CPAN::Meta::Spec",
version => 2,
},
);
Expand Down Expand Up @@ -101,7 +101,7 @@ my %first_expected = (
},
dynamic_config => 1,
'meta-spec' => {
url => "http://search.cpan.org/perldoc?CPAN::Meta::Spec",
url => "https://metacpan.org/pod/CPAN::Meta::Spec",
version => 2,
},
);
Expand Down Expand Up @@ -129,7 +129,7 @@ my %provides_merge_expected = (
},
},
'meta-spec' => {
url => "http://search.cpan.org/perldoc?CPAN::Meta::Spec",
url => "https://metacpan.org/pod/CPAN::Meta::Spec",
version => 2,
},
);
Expand Down
4 changes: 2 additions & 2 deletions t/meta-obj.t
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ my $distmeta = {
keywords => [ qw/ toolchain cpan dual-life / ],
'meta-spec' => {
version => '2',
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
url => 'https://metacpan.org/pod/CPAN::Meta::Spec',
},
generated_by => 'Module::Build version 0.36',
x_authority => 'cpan:FLORA',
Expand Down Expand Up @@ -148,7 +148,7 @@ is_deeply(
$meta->meta_spec,
{
version => '2',
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
url => 'https://metacpan.org/pod/CPAN::Meta::Spec',
},
'->meta_spec',
);
Expand Down
2 changes: 1 addition & 1 deletion t/no-index.t
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ my %distmeta = (
license => [ 'perl_5' ],
'meta-spec' => {
version => '2',
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
url => 'https://metacpan.org/pod/CPAN::Meta::Spec',
},
dynamic_config => 1,
generated_by => 'Module::Build version 0.36',
Expand Down
2 changes: 1 addition & 1 deletion t/optional_feature-merge.t
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ my %base = (
},
},
'meta-spec' => {
url => "http://search.cpan.org/perldoc?CPAN::Meta::Spec",
url => "https://metacpan.org/pod/CPAN::Meta::Spec",
version => 2,
},
);
Expand Down
2 changes: 1 addition & 1 deletion t/save-load.t
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ my $distmeta = {
keywords => [ qw/ toolchain cpan dual-life / ],
'meta-spec' => {
version => '2',
url => 'http://search.cpan.org/perldoc?CPAN::Meta::Spec',
url => 'https://metacpan.org/pod/CPAN::Meta::Spec',
},
generated_by => 'Module::Build version 0.36',
};
Expand Down