Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approx kde #22

Closed
wants to merge 2 commits into from
Closed

approx kde #22

wants to merge 2 commits into from

Conversation

Parskatt
Copy link
Owner

@Parskatt Parskatt commented Feb 7, 2024

No description provided.

@Parskatt Parskatt mentioned this pull request Feb 7, 2024
Open
@Parskatt
Copy link
Owner Author

Parskatt commented Feb 7, 2024

@ducha-aiki can you check this out?

@ducha-aiki
Copy link

Thank you, will check tomorrow

@Parskatt
Copy link
Owner Author

Parskatt commented Feb 8, 2024 •
edited
Loading

It could also work to replace the balanced sampling with NMS kind of similar to casmtr. Havent tried though.

Basically we just want a nice spread of the matches.

@ducha-aiki
Copy link 

    matches, match_certainty = matcher.sample(warp, certainty, num=roma_max_matches)
  File "/RoMa/roma/models/matcher.py", line 487, in sample
    density = approx_kde(good_matches, std=0.1)
  File "/RoMa/roma/utils/kde.py", line 16, in approx_kde
    y = torch.multinomial(x, min(max_num_cmp,len(x.shape[-2])), replacement=False)
TypeError: object of type 'int' has no len()

@Parskatt
Copy link
Owner Author

Moved to #23

@Parskatt Parskatt closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parskatt @ducha-aiki