Extract SetParsedProvinceRank (#1940) #patch

ParadoxGameConverters · May 8, 2024 · 3b2f47b · 3b2f47b
1 parent 116d199
commit 3b2f47b
Showing 1 changed file with 22 additions and 17 deletions.
diff --git a/ImperatorToCK3/Imperator/Provinces/ProvinceFactory.cs b/ImperatorToCK3/Imperator/Provinces/ProvinceFactory.cs
@@ -29,23 +29,7 @@ static Province() {
 		provinceParser.RegisterKeyword("civilization_value", reader =>
 			parsedProvince.CivilizationValue = reader.GetDouble()
 		);
-		provinceParser.RegisterKeyword("province_rank", reader => {
-			var provinceRankStr = reader.GetString();
-			switch (provinceRankStr) {
-				case "settlement":
-					parsedProvince.ProvinceRank = ProvinceRank.settlement;
-					break;
-				case "city":
-					parsedProvince.ProvinceRank = ProvinceRank.city;
-					break;
-				case "city_metropolis":
-					parsedProvince.ProvinceRank = ProvinceRank.city_metropolis;
-					break;
-				default:
-					Logger.Warn($"Unknown province rank for province {parsedProvince.Id}: {provinceRankStr}");
-					break;
-			}
-		});
+		provinceParser.RegisterKeyword("province_rank", SetParsedProvinceRank());
 		provinceParser.RegisterKeyword("fort", reader =>
 			parsedProvince.Fort = reader.GetBool()
 		);
@@ -71,6 +55,27 @@ static Province() {
 		});
 		provinceParser.IgnoreAndStoreUnregisteredItems(IgnoredTokens);
 	}
+
+	private static SimpleDel SetParsedProvinceRank() {
+		return reader => {
+			var provinceRankStr = reader.GetString();
+			switch (provinceRankStr) {
+				case "settlement":
+					parsedProvince.ProvinceRank = ProvinceRank.settlement;
+					break;
+				case "city":
+					parsedProvince.ProvinceRank = ProvinceRank.city;
+					break;
+				case "city_metropolis":
+					parsedProvince.ProvinceRank = ProvinceRank.city_metropolis;
+					break;
+				default:
+					Logger.Warn($"Unknown province rank for province {parsedProvince.Id}: {provinceRankStr}");
+					break;
+			}
+		};
+	}
+
 	public static Province Parse(BufferedReader reader, ulong provinceId, StateCollection states, CountryCollection countries) {
 		parsedStateId = null;
 		parsedOwnerId = null;