Skip to content
Build development version

Make more classes internal, reduce interface use #1653

Sign in to view logs

Make more classes internal, reduce interface use

Make more classes internal, reduce interface use #1653

Triggered via push December 16, 2024 02:04
@IhateTrainsIhateTrains
pushed 39754c8
internal-classes
Status Success
Total duration 6m 4s
Artifacts –

build_dev_version.yml

on: push
Matrix: Upload development build
Fit to window
Zoom out
Zoom in

Annotations

40 warnings
Upload development build (linux-x64): Fronter.NET/Fronter.NET/obj/Release/linux-x64/gen.cs#L1
Upload development build (linux-x64): Fronter.NET/Fronter.NET/obj/Release/linux-x64/gen.cs#L1
Upload development build (linux-x64): Fronter.NET/Fronter.NET/Services/MessageSlicer.cs#L55
Regular expressions should not be vulnerable to Denial of Service attacks (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0009.md)
Upload development build (linux-x64): Fronter.NET/Fronter.NET/Extensions/TranslationSource.cs#L165
Regular expressions should not be vulnerable to Denial of Service attacks (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0009.md)
Upload development build (linux-x64): Fronter.NET/Fronter.NET/ViewModels/MainWindowViewModel.cs#L187
Method is too long (66 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (linux-x64): Fronter.NET/Fronter.NET/Models/Configuration/Config.cs#L313
Method is too long (67 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (linux-x64): Fronter.NET/Fronter.NET/Services/UpdateChecker.cs#L60
Method is too long (65 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (linux-x64): Fronter.NET/Fronter.NET/Services/ConverterLauncher.cs#L50
Method is too long (125 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (linux-x64): Fronter.NET/Fronter.NET/LauncherDbContext.cs#L35
Method is too long (269 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (linux-x64): Fronter.NET/Fronter.NET/Services/ModCopier.cs#L21
Method is too long (118 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L164
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L173
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L182
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L191
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L207
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L214
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L221
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L322
TODO CHECK IF BALD CHARACTERS STILL CORRECTLY APPEAR BALD IN CK3 (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/CK3LocDB.cs#L93
TODO add unit test for combining loc from all the sources into one locblock (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (linux-x64): ImperatorToCK3/CK3/Cultures/CultureCollection.cs#L218
Upload development build (win-x64): Fronter.NET/Fronter.NET/obj/Release/win-x64/gen.cs#L1
Upload development build (win-x64): Fronter.NET/Fronter.NET/obj/Release/win-x64/gen.cs#L1
Upload development build (win-x64): Fronter.NET/Fronter.NET/Services/MessageSlicer.cs#L55
Regular expressions should not be vulnerable to Denial of Service attacks (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0009.md)
Upload development build (win-x64): Fronter.NET/Fronter.NET/Extensions/TranslationSource.cs#L165
Regular expressions should not be vulnerable to Denial of Service attacks (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0009.md)
Upload development build (win-x64): Fronter.NET/Fronter.NET/Services/ConverterLauncher.cs#L50
Method is too long (125 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (win-x64): Fronter.NET/Fronter.NET/Services/ModCopier.cs#L21
Method is too long (118 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (win-x64): Fronter.NET/Fronter.NET/Services/ModCopier.cs#L141
Method is too long (94 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (win-x64): Fronter.NET/Fronter.NET/Services/UpdateChecker.cs#L60
Method is too long (65 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (win-x64): Fronter.NET/Fronter.NET/ViewModels/MainWindowViewModel.cs#L187
Method is too long (66 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (win-x64): Fronter.NET/Fronter.NET/Models/Configuration/Config.cs#L313
Method is too long (67 lines; maximum allowed: 60) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0051.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L164
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L173
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L182
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L191
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L207
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L214
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L221
TODO check if this is correctly added to portrait modifiers if needed (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Characters/DNAFactory.cs#L322
TODO CHECK IF BALD CHARACTERS STILL CORRECTLY APPEAR BALD IN CK3 (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/CK3LocDB.cs#L93
TODO add unit test for combining loc from all the sources into one locblock (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
Upload development build (win-x64): ImperatorToCK3/CK3/Cultures/CultureCollection.cs#L218