Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read/write of disabled controls to input file #827

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

LRossman
Copy link
Collaborator

Addresses issue #822.

@eladsal
Copy link
Member

eladsal commented Feb 14, 2025

Looks good. Thank you @LRossman .

Do we need to add something to ReleaseNotes2_3.md?

@LRossman
Copy link
Collaborator Author

On my local branch I added the following sentence to the existing Release Notes item that first mentioned the additional API functions for enabling/disabling controls:
A new keyword DISABLED is added to the end of a control or rule statement in an EPANET input file to indicate that the control is disabled.
But I forgot to include the updated Notes file in this PR. I will do so at a later date when I will also re-format the notes into sections (New Features, Updated Features, Bug Fixes) to make it easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants