Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on first login after password change #4550

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix error on first login after password change #4550

merged 3 commits into from
Jan 24, 2025

Conversation

bastianjoel
Copy link
Member

resolves #4143

@bastianjoel bastianjoel added this to the 4.3 milestone Jan 15, 2025
@bastianjoel bastianjoel requested review from rrenkert and MSoeb January 15, 2025 15:04
Elblinator
Elblinator approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality and code

reiterl
reiterl approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Okay to me.
Seems to work in my test.

MSoeb
MSoeb requested changes Jan 22, 2025
View reviewed changes
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but after password change an error occurs multiple times in the console, which needs to be fixed.

image

Reproduction:

  1. open account menu
  2. open console
  3. open password change menu. change password and save it -> errors occur.

@Elblinator Elblinator assigned bastianjoel and unassigned rrenkert and MSoeb Jan 22, 2025
@bastianjoel bastianjoel requested a review from MSoeb January 24, 2025 09:03
@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Jan 24, 2025
MSoeb
MSoeb approved these changes Jan 24, 2025
View reviewed changes
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bastianjoel bastianjoel merged commit 390f8aa into OpenSlides:main Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSoeb MSoeb MSoeb approved these changes

@Elblinator Elblinator Elblinator approved these changes

@reiterl reiterl reiterl approved these changes

@rrenkert rrenkert Awaiting requested review from rrenkert

Assignees

@MSoeb MSoeb

Labels
bug
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Password Change didn't work well
5 participants
@bastianjoel @reiterl @Elblinator @MSoeb @rrenkert