Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of microphone in speakers list #4519

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anbebe
Copy link
Contributor

@anbebe anbebe commented Jan 8, 2025

Closes #4407

@anbebe anbebe added the enhancement General enhancement which is neither bug nor feature label Jan 8, 2025
@anbebe anbebe added this to the 4.3 milestone Jan 8, 2025
@anbebe anbebe requested review from Elblinator and MSoeb January 8, 2025 15:47
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Mic icon is not alligned correcly, see red line in screenshot:

image

The left side of the mic icon should placed at the red line.

@Elblinator Elblinator assigned anbebe and unassigned Elblinator and MSoeb Jan 14, 2025
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

@Elblinator Elblinator removed their assignment Jan 16, 2025
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an error, which occurs with motions that have visibility restrictions. If I project a motion with the workflow 'complex' and add someone to the list of speakers an error occurs in the console. I've checked the behavior on our test instance and it didn't occur. So I assume, that the PR is somehow related to the problem. Could you please check this? - Except of this, the position of the icon looks good.

Error message:
image

Reproduction:

  1. open a meeting
  2. open motions. create a motion with complex workflow. don't change state -> project it
  3. open console
  4. open Autopilot. Add someone to list or push the Play button. Interactions with the list of speakers leads to errors.

@MSoeb MSoeb assigned anbebe and unassigned emanuelschuetze and MSoeb Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of speakers: listing layout optimization
4 participants