Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the orgaadmin to do more #2744

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Nov 27, 2024

Closes #2737
Also allow cloning and deleting of locked meetings as long as the caller has settings manage perms in that meeting

Also allow cloning and deleting of locked meetings as long as the caller
has settings manage perms in that meeting
@luisa-beerboom luisa-beerboom added this to the 4.2 milestone Nov 27, 2024
@luisa-beerboom luisa-beerboom self-assigned this Nov 27, 2024
@luisa-beerboom luisa-beerboom marked this pull request as ready for review November 28, 2024 14:12
Copy link
Member

@hjanott hjanott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added some suggestions of which some repeat in other places of the code.

tests/system/action/meeting/test_update.py Show resolved Hide resolved
tests/system/action/meeting/test_delete.py Show resolved Hide resolved
tests/system/action/meeting/test_delete.py Show resolved Hide resolved
openslides_backend/action/actions/meeting/mixins.py Outdated Show resolved Hide resolved
@Elblinator Elblinator modified the milestones: 4.2, 4.3 Dec 13, 2024
@Elblinator Elblinator assigned bspekker and unassigned Elblinator Dec 16, 2024
@Elblinator Elblinator requested review from bspekker and removed request for Elblinator December 16, 2024 14:30
@Elblinator Elblinator assigned MSoeb and unassigned bspekker Jan 22, 2025
@Elblinator Elblinator requested review from MSoeb and removed request for bspekker and Elblinator January 22, 2025 11:47
@Elblinator Elblinator removed their assignment Jan 22, 2025
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some permission issue: All is tested as Orgaadmin which is not part of a committee or meeting.

  • Committee menu: Create a meeting is not possible. Orgaadmin needs to be committee admin to create a committee. Following the superadmin permissions, this should be possible without setting the orgaadmin as committee admin.
    image

  • Committe menu > meeting edit: Edit is not possible. Wanted behavior: Same as above.
    image

  • Meeting > Participants > Add or edit a user: Adding or editing a participant doesn't work. Permission is missing. Wanted behavior: Should work, without being a part (admin) of the meeting.
    image

  • Motions > create a motion: Didn't work if the submitter is a new participant. This is a follow up of the previous point. I assume, that this behavior will happen on every action that requires to add or edit a participant. Wanted behavior: Creating a motionwithout being part of the meeting should be possible. Just like superadmins can do it.
    image

  • Meeting > Autopilot: If something is projected, that provides the possibility to create a point of order, this action doesn't work. An error appears, because the orgaadmin is not part of the meeting. -> Creating a point of order should be possible, just like it is for a superadmin.
    image

@MSoeb MSoeb assigned luisa-beerboom and unassigned MSoeb Jan 23, 2025
@luisa-beerboom luisa-beerboom force-pushed the 2737-restriction-change-for-orgaadmin branch from 92af550 to b639322 Compare January 27, 2025 10:06
@luisa-beerboom
Copy link
Member Author

I'll preface this by saying: If you want backend development to run efficiently please provide payloads if something's not working. Otherwise the bugs may be hard to replicate.

Also: From the fact that I couldn't even replicate the easy-to-understand ones, I wonder if maybe you tested with the wrong backend version.

Found some permission issue: All is tested as Orgaadmin which is not part of a committee or meeting.

* Committee menu: Create a meeting is not possible. Orgaadmin needs to be committee admin to create a committee. Following the superadmin permissions, this should be possible without setting the orgaadmin as committee admin.

Couldn't replicate.

* Committe menu > meeting edit: Edit is not possible. Wanted behavior: Same as above.

There's some fields that shouldn't be working, like the jitsi fields, however I can't tell if they're the ones causing problems for you. Please tell me what fields are causing problems specifically (maybe using the action documentation for meeting.update as a guideline) and please provide a payload anyway.

* Meeting > Participants > Add or edit a user: Adding or editing a participant doesn't work. Permission is missing. Wanted behavior: Should work, without being a part (admin) of the meeting.

Couldn't replicate, neither with user.create nor user.update.

* Motions > create a motion: Didn't work if the submitter is a new participant. This is a follow up of the previous point. I assume, that this behavior will happen on every action that requires to add or edit a participant. Wanted behavior: Creating a motionwithout being part of the meeting should be possible. Just like superadmins can do it.

As far as I know the client adds the new user separately. Since there are two actions involved, I can't even tell if this is actually a backend problem, or if the client is doing something wrong.

* Meeting > Autopilot: If something is projected, that provides the possibility to create a point of order, this action doesn't work. An error appears, because the orgaadmin is not part of the meeting. -> Creating a point of order should be possible, just like it is for a superadmin.

I don't fully grasp what situation you are talking about, since projection dont' have points of order. Also the snackbar message is clearly a client-side error. While this may just be a chain reaction thing caused by a backend error, I really can't tell what the error would actually be, so please provide more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restriction change for Orgaadmin
5 participants