-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the orgaadmin to do more #2744
base: main
Are you sure you want to change the base?
Allow the orgaadmin to do more #2744
Conversation
Also allow cloning and deleting of locked meetings as long as the caller has settings manage perms in that meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added some suggestions of which some repeat in other places of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some permission issue: All is tested as Orgaadmin which is not part of a committee or meeting.
-
Committee menu: Create a meeting is not possible. Orgaadmin needs to be committee admin to create a committee. Following the superadmin permissions, this should be possible without setting the orgaadmin as committee admin.
-
Committe menu > meeting edit: Edit is not possible. Wanted behavior: Same as above.
-
Meeting > Participants > Add or edit a user: Adding or editing a participant doesn't work. Permission is missing. Wanted behavior: Should work, without being a part (admin) of the meeting.
-
Motions > create a motion: Didn't work if the submitter is a new participant. This is a follow up of the previous point. I assume, that this behavior will happen on every action that requires to add or edit a participant. Wanted behavior: Creating a motionwithout being part of the meeting should be possible. Just like superadmins can do it.
-
Meeting > Autopilot: If something is projected, that provides the possibility to create a point of order, this action doesn't work. An error appears, because the orgaadmin is not part of the meeting. -> Creating a point of order should be possible, just like it is for a superadmin.
92af550
to
b639322
Compare
I'll preface this by saying: If you want backend development to run efficiently please provide payloads if something's not working. Otherwise the bugs may be hard to replicate. Also: From the fact that I couldn't even replicate the easy-to-understand ones, I wonder if maybe you tested with the wrong backend version.
Couldn't replicate.
There's some fields that shouldn't be working, like the jitsi fields, however I can't tell if they're the ones causing problems for you. Please tell me what fields are causing problems specifically (maybe using the action documentation for meeting.update as a guideline) and please provide a payload anyway.
Couldn't replicate, neither with user.create nor user.update.
As far as I know the client adds the new user separately. Since there are two actions involved, I can't even tell if this is actually a backend problem, or if the client is doing something wrong.
I don't fully grasp what situation you are talking about, since projection dont' have points of order. Also the snackbar message is clearly a client-side error. While this may just be a chain reaction thing caused by a backend error, I really can't tell what the error would actually be, so please provide more information |
Closes #2737
Also allow cloning and deleting of locked meetings as long as the caller has settings manage perms in that meeting