Rework Shulker Box Folder Settings #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #105
List of Changes
_DEFAULTS
lookup_DEFAULTS
can now be overwritten inenderchest.cfg
, including the list of default folders inside a shulker box and the "standard" and "global" lists of link-foldersTech Debt and Other Concerns
Since these folder settings aren't written to the config if they're not already in the config, it might be worth creating a definitive configuration guide. Then again, #80 is another way to solve this issue.
Validation Performed
config/litematica
is a link-folder in a "global" shulker boxenderchest craft shulker_box
prompt a few times until I was satisfied with the prompt message and the general user experience of specifying global vs. standard vs. none vs. manualPR Type
release (will require rebasing off of
release
)Checklist:
mkdocs serve
locally and ensured that all API docs andchanges I have made to the static pages are rendering correctly, with all links
working
accepted
the GNU Public License v3