Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS runner to macos-13 #1435

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

feltech
Copy link
Member

@feltech feltech commented Jan 3, 2025

Description

Closes #1434. GitHub CI has started rejecting macOS 12, i.e.

The macOS-12 environment is deprecated, consider switching to macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see actions/runner-images#10721

VFX Reference Platform CY2024 only specifies a Minimum Deployment Target of 11.0 (CY2025 specifies 12.0). So we cannot match our GitHub runner to VFX CY2024. Nearest we can do is target the lowest available macOS version.

  • I have updated the release notes.
  • I have updated all relevant user documentation.

@feltech feltech self-assigned this Jan 3, 2025
@feltech feltech requested a review from a team as a code owner January 3, 2025 14:02
@feltech feltech changed the title [CI] Update macOS runner to macos-13 Update macOS runner to macos-13 Jan 3, 2025
@feltech feltech marked this pull request as draft January 3, 2025 14:04
@feltech feltech force-pushed the work/1434-ciMacOSVersion branch from c21cac3 to 116860a Compare January 3, 2025 14:07
Closes OpenAssetIO#1434. GitHub CI has started rejecting macOS 12, i.e.

> The macOS-12 environment is deprecated, consider switching to
> macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see
> actions/runner-images#10721

VFX Reference Platform CY2024 only specifies a Minimum Deployment Target
of 11.0 (CY2025 specifies 12.0). So we cannot match our GitHub runner to
VFX CY2024. Nearest we can do is target the lowest available macOS
version.

So update to `macos-13` runners.

The (default) available compiler on these is apple-clang 15, which isn't
an available option in Conan 1.59 ("ERROR: Invalid setting '15' is not a
valid 'settings.compiler.version' value"), so bump the version of Conan
to the latest v1 at time of writing, i.e. 1.66.

Signed-off-by: David Feltell <[email protected]>
@feltech feltech force-pushed the work/1434-ciMacOSVersion branch from 116860a to f4964a6 Compare January 3, 2025 16:18
@feltech feltech marked this pull request as ready for review January 3, 2025 16:29
@foundry-markf
Copy link

I did a search through GitHub's web interface, and couldn't find macosx-version-min=11.0 (or 12.0) specified anywhere.

Although you couldn't check with these actions that the min version is honoured, you can at least compile against it, as there are checks in the Xcode APIs if you're using functions that are not supported on the older versions.

@feltech
Copy link
Member Author

feltech commented Jan 6, 2025

I did a search through GitHub's web interface, and couldn't find macosx-version-min=11.0 (or 12.0) specified anywhere.

Although you couldn't check with these actions that the min version is honoured, you can at least compile against it, as there are checks in the Xcode APIs if you're using functions that are not supported on the older versions.

Yeah we do set(CMAKE_OSX_DEPLOYMENT_TARGET 11) in CMake, as well as the MACOSX_DEPLOYMENT_TARGET env var for cibuildwheel (for creating Python wheels), so I hope that adds some validation.

Copy link

@foundry-markf foundry-markf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the min version is set (I hadn't spotted it in CMake variables), then this should be fine, and will complain at compile/link time of anything untoward.

It's a pity we can't validate it on the desired machinery, but we can do that in other ways in the consumers of OpenAssetIO.

@feltech feltech merged commit 74e3fb4 into OpenAssetIO:main Jan 7, 2025
39 checks passed
@feltech feltech deleted the work/1434-ciMacOSVersion branch January 7, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to non-deprecated GitHub macOS runner version
2 participants