-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claim OctoPrint-Filetypes #1094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor adjustments that need to be taken care of.
_plugins/filetypes.md
Outdated
description: Let you select file types visible in upload dialog | ||
author: thelongrunsmoke | ||
description: Lets you control which file extensions are allowed to be uploaded thru the 'Upload' and 'Upload to SD' buttons. | ||
author: Kestin Goforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert this to authors as a list.
authors:
- Kestin Goforth
- thelongrunsmoke
_plugins/filetypes.md
Outdated
|
||
Go to 'Settings' -> 'Filetypes Plugin' and configure the extensions you need. | ||
|
||
![Settings](https://raw.githubusercontent.com/kforth/OctoPrint-Filetypes/doc/settings.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to internal image /assets/img/plugins/filetypes/settings.png
What is the use case for this plugin these days? It mentions a lot on the repo about adding file types that other plugins support uploading to this plugin. However, other plugins can do that themselves with the |
Ah yes, that does exactly what I wanted and with better functionality. I was looking to add support for some other file types and found this plugin which fixed the first half of my problem, tho I see now that the file extension support solves both halves of my problem (client half and server half). I just figured I'd update this plugin while I was modifying its code anyway. I suppose the use case is now fixing old or broken plugins while also breaking newer plugins if you don't enter every file type. The functionality of the original plugin is pretty much obsolete then:
Closing this PR and leaving the plugin abandoned since it's probably not worth updating. |
I have forked and updated the OctoPrint-Filetypes plugin and would like the become the new maintainer, see kforth/OctoPrint-Filetypes.
This plugin has not been updated in almost 5 years and was marked as abandoned over a year ago (#796), no one has since claimed it.
If preferred, I can submit this as a new plugin instead of claiming the abandoned one.
Suggestions are always appreciated.