Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove slash accidently added. Fixing card codes. Adjust font for Mobile App edition and Added qr codes for the bridge layout #659

Merged
merged 29 commits into from
Jul 8, 2024
Merged

Remove slash accidently added. Fixing card codes. Adjust font for Mobile App edition and Added qr codes for the bridge layout #659

merged 29 commits into from
Jul 8, 2024

Conversation

sydseter
Copy link
Collaborator

@sydseter sydseter commented Jul 5, 2024 •
edited
Loading

In this pull-request:

  • I screwed up the build by accidently adding a forward slash. This is now fixed.
  • Added qr codes for the bridge layout
  • Aligned the Mobile App edition description font with the Website App description fonts.
  • Changed the card codes for Authentication from AC to AT and the card codes for Data Validation & Encoding from DV to VE.
  • Changed the build back to generating all layouts to align this with the pre-release and release in order to better test the generation of all layouts.

owasp_cornucopia_webapp_2.00_cards_tarot_qr_en.pdf
owasp_cornucopia_webapp_2.00_cards_tarot_en.pdf
owasp_cornucopia_mobileapp_1.00_cards_tarot_qr_en.pdf
owasp_cornucopia_webapp_2.00_cards_bridge_qr_en.pdf

@sydseter sydseter requested review from rewtd and cw-owasp July 5, 2024 20:25
rewtd
rewtd previously requested changes Jul 7, 2024
View reviewed changes
source/webapp-cards-2.00-en.yaml Show resolved Hide resolved
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-eop-1.0.zip (c836e)
5a9e455 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_mobileapp_1.00_en.zip (c836e)
54f9096 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_en.zip (c836e)
2251f3c 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_en.zip (c836e)
d93fd83 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_es.docx (c836e)
5a64a4a 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_fr.docx (c836e)
7712fef 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_nl.docx (c836e)
dbe17bc 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_no-nb.docx (c8…
cb6a0a1 
…36e)

Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_pt-br.docx (c8…
483dc2b 
…36e)

Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_qr_en.docx (c8…
5c38865 
…36e)

Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_en.docx (c836e)
4865288 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_es.docx (c836e)
0c2e3f9 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_fr.docx (c836e)
196efc7 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_nl.docx (c836e)
b0b3a9a 
Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_no-nb.docx (c8…
da0d489 
…36e)

Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_pt-br.docx (c8…
5098309 
…36e)

Pull request: #659
Commit: c836ebb
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2024 •
edited
Loading

🤖 Pull request artifacts

The generated Cornucopia cards in this pull request.

file commit
eop-1.0.zip 3bc407c
owasp_cornucopia_mobileapp_1.00_en.zip 3bc407c
owasp_cornucopia_webapp_1.22_en.zip 3bc407c
owasp_cornucopia_webapp_2.00_en.zip 3bc407c
owasp_cornucopia_webapp_1.22_guide_bridge_es.docx 3bc407c
owasp_cornucopia_webapp_1.22_guide_bridge_fr.docx 3bc407c
owasp_cornucopia_webapp_1.22_guide_bridge_nl.docx 3bc407c
owasp_cornucopia_webapp_1.22_guide_bridge_no-nb.docx 3bc407c
owasp_cornucopia_webapp_1.22_guide_bridge_pt-br.docx 3bc407c
owasp_cornucopia_webapp_1.22_guide_bridge_qr_en.docx 3bc407c
owasp_cornucopia_webapp_2.00_guide_bridge_en.docx 3bc407c
owasp_cornucopia_webapp_2.00_guide_bridge_es.docx 3bc407c
owasp_cornucopia_webapp_2.00_guide_bridge_fr.docx 3bc407c
owasp_cornucopia_webapp_2.00_guide_bridge_nl.docx 3bc407c
owasp_cornucopia_webapp_2.00_guide_bridge_no-nb.docx 3bc407c
owasp_cornucopia_webapp_2.00_guide_bridge_pt-br.docx 3bc407c
owasp_cornucopia_webapp_2.00_guide_bridge_qr_en.docx 3bc407c

github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_qr_en.docx (c8…
8675e8c 
…36e)

Pull request: #659
Commit: c836ebb
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-eop-1.0.zip (8a9b3)
b27927e 
Pull request: #659
Commit: 8a9b3ae
github-actions bot added a commit that referenced this pull request Jul 7, 2024
@github-actions
Upload pr659-owasp_cornucopia_mobileapp_1.00_en.zip (8a9b3)
52bbb44 
Pull request: #659
Commit: 8a9b3ae
cw-owasp
cw-owasp previously approved these changes Jul 8, 2024
View reviewed changes
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-eop-1.0.zip (5552e)
1c8917c 
Pull request: #659
Commit: 5552e03
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_mobileapp_1.00_en.zip (5552e)
a4e955b 
Pull request: #659
Commit: 5552e03
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_en.zip (5552e)
44b8fd0 
Pull request: #659
Commit: 5552e03
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_en.zip (5552e)
c2b7933 
Pull request: #659
Commit: 5552e03
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-eop-1.0.zip (3bc40)
f7a2869 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_mobileapp_1.00_en.zip (3bc40)
dadc18b 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_en.zip (3bc40)
77be08e 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_en.zip (3bc40)
ff46298 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_es.docx (3bc40)
14c6a34 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_fr.docx (3bc40)
551a4e4 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_nl.docx (3bc40)
3477663 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_no-nb.docx (3b…
0444ca7 
…c40)

Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_pt-br.docx (3b…
bad0d0e 
…c40)

Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_1.22_guide_bridge_qr_en.docx (3b…
1d393ed 
…c40)

Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_en.docx (3bc40)
660dc97 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_es.docx (3bc40)
e89fe2f 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_fr.docx (3bc40)
dc711bf 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_nl.docx (3bc40)
1c108f6 
Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_no-nb.docx (3b…
4229413 
…c40)

Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_pt-br.docx (3b…
e6d8146 
…c40)

Pull request: #659
Commit: 3bc407c
github-actions bot added a commit that referenced this pull request Jul 8, 2024
@github-actions
Upload pr659-owasp_cornucopia_webapp_2.00_guide_bridge_qr_en.docx (3b…
a29bd57 
…c40)

Pull request: #659
Commit: 3bc407c
rewtd
rewtd approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@rewtd rewtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sydseter sydseter dismissed rewtd’s stale review July 8, 2024 15:21

Dismissing to be able to merge.

@sydseter sydseter merged commit 07ebb7e into master Jul 8, 2024
14 checks passed
@sydseter sydseter deleted the eop-build branch July 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cw-owasp cw-owasp cw-owasp approved these changes

@rewtd rewtd rewtd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydseter @rewtd @cw-owasp