Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] automatically remove @odoo-module from js assets #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] automatically remove @odoo-module from js assets #108

wants to merge 1 commit into from
+50 −0

Conversation

xaviedoanhduy
Copy link

no need for /** @odoo-module */ anymore

automatically remove it from js assets: https://github.com/odoo/odoo/pull/142858/

@lef-adhoc
Copy link
Contributor

Should you check that it is in the /static/tests or /static/src folders?

@xaviedoanhduy
Copy link
Author

hi @lef-adhoc,
thanks for the idea
added the code.

lef-adhoc
lef-adhoc approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@lef-adhoc lef-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@legalsylvain @jjscarafia could you do a review?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lef-adhoc lef-adhoc lef-adhoc approved these changes

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xaviedoanhduy @lef-adhoc @OCA-git-bot @bosd