Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build checks for app/client and landing page #285

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

gelluisaac
Copy link
Contributor

Description

This PR modifies the workflow to check for build errors in the app/client and landing page, in addition to the existing contract tests. The changes ensure that the CI/CD pipeline fails if any build errors occur, improving the reliability of the deployment process.

Changes

  • Added a new job (build-client) to the GitHub Actions workflow.
  • The build-client job:
    • Sets up Node.js and installs dependencies for app/client.
    • Builds the app/client using npm run build.
    • Builds the landing page using npm run build-landing-page.
  • Updated the package.json to include the build-landing-page script.

Related Issues
Closes #

Type of Change

  • 🐛 Bug fix or ⚙️ enhancement
  • ✨ New feature or Chore (change with no new features or fixes)
  • 📚 Documentation update

Testing

  • Verified that the workflow runs successfully in GitHub Actions.
  • Manually tested the app/client and landing page builds locally.
  • Confirmed that the workflow fails if build errors are introduced.

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@Solomonsolomonsolomon
Copy link
Contributor

@gelluisaac any updates on the PR?

@gelluisaac
Copy link
Contributor Author

working on it now sir

@Solomonsolomonsolomon Solomonsolomonsolomon merged commit 40f86a8 into NoshonNetworks:main Jan 27, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants