Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register land modal and typescript config #268

Closed

Conversation

MarcusDavidG
Copy link

@MarcusDavidG MarcusDavidG commented Dec 26, 2024

  • Fixed import paths in RegisterLandModal.tsx
  • Fixed TypeScript configuration in tsconfig.json
  • Removed package-lock.json in favor of pnpm
  • Added proper type annotations

Detailed Information


Related Issues

Closes #251


Type of Change

  • 🐛 Bug fix or ⚙️ enhancement
  • ✨ New feature or Chore (change with no new features or fixes)
  • 📚 Documentation update

Checklist (select as many as applicable)

  • The code follows the style guidelines of this project.
  • All new and existing tests pass.
  • This pull request is ready to be merged and reviewed.

- Fixed import paths in RegisterLandModal.tsx
- Fixed TypeScript configuration in tsconfig.json
- Removed package-lock.json in favor of pnpm
- Added proper type annotations
@Solomonsolomonsolomon
Copy link
Contributor

please add issue number

@MarcusDavidG
Copy link
Author

Done!

@Solomonsolomonsolomon
Copy link
Contributor

i dont see the map picker, can you include relevant screenshots

@MarcusDavidG
Copy link
Author

MarcusDavidG commented Dec 28, 2024

Map Piclker(longitude and latitude)

The Latitude and Longitude coordinates are used to pin point the exact location on the map

@Solomonsolomonsolomon
Copy link
Contributor

This doesn't align with the issue, the issue was to replace the latitude and longitude fields with a map picker, so users pick their location from a map , not entering the lat and lon manually

Copy link
Contributor

@Solomonsolomonsolomon Solomonsolomonsolomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-read issue #240 again as this doesn't tally with the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants