Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: startknet indexer #260

Merged
merged 3 commits into from
Dec 25, 2024
Merged

feat: startknet indexer #260

merged 3 commits into from
Dec 25, 2024

Conversation

rajiabdul
Copy link
Contributor

@rajiabdul rajiabdul commented Dec 23, 2024

Detailed Information


Related Issues

Closes #236


Type of Change

  • πŸ› Bug fix or βš™οΈ enhancement
  • ✨ New feature or Chore (change with no new features or fixes)
  • πŸ“š Documentation update

Checklist (select as many as applicable)

  • The code follows the style guidelines of this project.
  • All new and existing tests pass.
  • This pull request is ready to be merged and reviewed.

@fishonamos fishonamos self-requested a review December 23, 2024 21:11
@fishonamos
Copy link
Member

Nice. Please separate db operations.

Copy link
Member

@fishonamos fishonamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great! Please effect the requested changes as soon as possible.

@rajiabdul
Copy link
Contributor Author

Will push my changes now!

@fishonamos fishonamos merged commit 4d51414 into NoshonNetworks:main Dec 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix the indexer and ensure it works
2 participants