landing page redirect #249
Conversation
removed. My bad. |
|
Please add the issue number to the description. |
app/client/package-lock.json
Outdated
There was a problem hiding this comment.
please we use pnpm instead of npm for app/client.kindly revert
land-registry-backend/src/app.ts
Outdated
| @@ -8,7 +8,7 @@ import { config } from "./config"; | |||
| const app = express(); | |||
|
|
|||
| // Middleware | |||
| app.use(helmet()); | |||
| // app.use(helmet()); | |||
There was a problem hiding this comment.
i noticed you commented out this line. might i ask why?
landing_page/src/app/lib/axios.ts
Outdated
| @@ -1,7 +1,7 @@ | |||
| import axios from "axios"; | |||
|
|
|||
| export const api = axios.create({ | |||
| baseURL: process.env.NEXT_PUBLIC_API_URL, | |||
| baseURL: 'http://localhost:3000', | |||
There was a problem hiding this comment.
please dont hardcode the base url
package.json
Outdated
| @@ -2,6 +2,13 @@ | |||
| "dependencies": { | |||
| "@apibara/indexer": "^0.4.1", | |||
| "@apibara/protocol": "^0.4.9", | |||
| "dotenv": "^16.4.7", | |||
There was a problem hiding this comment.
you're installing packages in the wrong directory
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
this is at the root folder,it is /app/client that uses a pnpm lock
package.json
Outdated
There was a problem hiding this comment.
youre installing deps in the root folder, this should be in the /land-registry-backend
There was a problem hiding this comment.
please restore file as land-registry-backend uses npm. its /app/client that uses pnpm
app/client/package-lock.json
Outdated
There was a problem hiding this comment.
app/client still has a package-lock. it should use a pnpm-lock
Detailed Information
Related Issues
Closes #242
Type of Change
Checklist (select as many as applicable)