Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.sonarlint-nvim: init at 2025-01-24 #377720

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

c3n21
Copy link

@c3n21 c3n21 commented Jan 29, 2025

This PR aims to add sonarlint.nvim to official repos.

Still testing because it doesn't work on my machine yet, I just managed to make it launch but I'm not receiving any linting for TypeScript

Things done

nix run .#vimPluginsUpdater -- add "https://gitlab.com/schrieveslaach/sonarlint.nvim"
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 29, 2025
@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch from 3d09f33 to 0a56c30 Compare February 2, 2025 09:38
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, all new non-github plugins should go to pkgs/applications/editors/vim/plugins/non-generated (#376366)

@c3n21
Copy link
Author

c3n21 commented Feb 2, 2025

image
Even passing nodejs explicitly as runtimeDeps it still gives me this error (to see that you should add this handler in your NeoVim config)

vim.lsp.handlers['sonarlint/canShowMissingRequirementsNotification'] = function()
    return true
end

I will try to run NeoVim in a Ubuntu VM to see if it's something strictly related to how Nix builds NeoVim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vim 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants