restinio: fix build #375955
Open
restinio: fix build #375955
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you open an issue for the |
Test builds fail with cmake configuration error: > string sub-command JSON failed parsing json string: * Line 1, Column 1 This is a silly regression from catch2_3 3.7.1 -> 3.8.0 bump [1]. Looks like the upstream doesn't hold catch2 correctly and overrides `main` for this test so catch2 test discovery machinery can't work. Upstream issue [2]. [1]: https://www.github.com/NixOS/nixpkgs/pull/371311 [2]: https://www.github.com/Stiffstream/restinio/issues/230
|
On second thought, this isn't a catch2 problem at all, but rather a restinio tests bug. Since |
xokdvium
force-pushed
the
fix/restinio
branch
from
a4f5250 to
53775e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test builds fail with cmake configuration error:
This is a silly regression from catch2_3 3.7.1 -> 3.8.0 bump 1.
Looks like the upstream doesn't hold catch2 correctly and overrides
mainfor this test so catch2 test discovery machinery can't work.
Upstream issue 2.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.