Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl3: 3.1.8 -> 3.2.0 #375829

Merged
merged 2 commits into from
Jan 22, 2025
Merged

sdl3: 3.1.8 -> 3.2.0 #375829

merged 2 commits into from
Jan 22, 2025

Conversation

nadiaholmquist
Copy link
Contributor

Updates SDL3 to the final release of 3.2.0. See changelog here: https://github.com/libsdl-org/SDL/releases/tag/release-3.2.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump!

If you have the time, could you also add vulkan-headers and vulkan-loader to dlopenPropagatedInputs (as suggested here)? It should be supported on (basically) all systems. If not, I can always make a follow up :)

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 22, 2025
@peterhoeg
Copy link
Member

This is a little off-topic, my apologies, but is anyone planning on working on sdl2-compat?

@nadiaholmquist
Copy link
Contributor Author

This is a little off-topic, my apologies, but is anyone planning on working on sdl2-compat?

I have a (currently untested) package for it locally that I could submit once this is merged, compared to SDL itself packaging it seems quite trivial.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@getchoo getchoo merged commit 949a79c into NixOS:master Jan 22, 2025
24 of 27 checks passed
@getchoo getchoo added the backport release-24.11 Backport PR automatically label Jan 22, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 22, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants