Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.w3lib: fix build with python 3.9 and 3.10 #375511

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 21, 2025

The fix for python/cpython#103848 /
CVE-2024-11168 also got backported to python 3.9.21 and 3.10.16, which is why the testsuite started failing.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The fix for python/cpython#103848 /
CVE-2024-11168 also got backported to python 3.9.21 and 3.10.16, which
is why the testsuite started failing.
Copy link
Member

@glittershark glittershark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@flokli flokli merged commit af9e505 into NixOS:master Jan 22, 2025
26 of 28 checks passed
@flokli flokli deleted the w3lib-py39-py310 branch January 22, 2025 18:13
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 22, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants