Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libretrack: init at 1.7.0 #374968

Merged
merged 1 commit into from
Jan 22, 2025
Merged

libretrack: init at 1.7.0 #374968

merged 1 commit into from
Jan 22, 2025
+2,076 −0

Conversation

genga898
Copy link
Contributor

Closes #317043
Add libretrack to nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 19, 2025
@Adda0
Copy link
Contributor

Adda0 commented Jan 19, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374968

x86_64-linux

✅ 1 package built:
  • libretrack

Reviewed points

✅ 25 | 🔴 0
  • All package paths fit the guidelines (e.g., pkgs/by-name/so/some-package/package.nix for top-level packages).
  • Package name fits guidelines.
  • Package version fits guidelines.
  • The packages sources are fetched using the appropriate functions (e.g., packages from GitHub should use fetchFromGitHub).
  • The package sources use mirror:// URLs when available.
  • tag is used instead of rev for tag versions.
  • hash is used instead of sha256 for hashes.
  • Build time only dependencies are declared in nativeBuildInputs or its equivalent in the used builder.
  • The list of phases is not overridden.
  • When a phase (like installPhase) is overridden, it starts with runHook preInstall and ends with runHook postInstall.
  • Patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed.
  • Patches that are remotely available are fetched rather than vendored.
  • Package builds on x86_64-linux.
  • Executables tested on x86_64-linux.
  • meta.description is set and fits guidelines.
    • Descriptions should not contain complete sentences and should consist of phrases that fill the blank in " is a/an/the ____" (starting with a capital letter).
  • meta.license fits upstream license.
  • meta.platforms should be set (or the package will not get binary substitutes).
  • Maintainers in meta.maintainers must be set.
    • This can be the package submitter or a community member that accepts taking up maintainership of the package.
  • The meta.mainProgram must be set if a main executable exists.
  • Whatever is needed is brought into scope instead of using top-level pkgs to make it easier to override.
  • General with lib; is not used.
  • If possible, update script is provided.
  • If possible, tests are provided.
  • The code contains no typos and all typos have been reported.

Possible improvements

The following errors are thrown when started. I am not sure if this is something we can fix here, however.

** (libretrack:615664): CRITICAL **: 08:44:40.689: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.690: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.690: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.691: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.691: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
(libretrack:615664): Atk-CRITICAL **: 08:44:40.691: atk_socket_embed: assertion 'plug_id != NULL' failed

Comments

The package builds and runs.

@genga898
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374968

x86_64-linux

✅ 1 package built:

  • libretrack

Reviewed points

✅ 25 | 🔴 0

Possible improvements

Comments

The package builds and runs.

The following errors are thrown when started. I am not sure if this is something we can fix here, however.

** (libretrack:615664): CRITICAL **: 08:44:40.689: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.690: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.690: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.691: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
** (libretrack:615664): CRITICAL **: 08:44:40.691: Failed to read XDG desktop portal settings: GDBus.Error:org.freedesktop.portal.Error.NotFound: Requested setting not found
(libretrack:615664): Atk-CRITICAL **: 08:44:40.691: atk_socket_embed: assertion 'plug_id != NULL' failed

I haven't gotten any errors when I ran it, don't really know what the issue could be.

@Adda0
Copy link
Contributor

Adda0 commented Jan 19, 2025 •
edited
Loading

Do not know, either. The application seems to work just fine. It might be a similar issue to what rustdesk/rustdesk#3975 fixes. See also the mentioned issue. But who knows.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 19, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374968

x86_64-linux

✅ 3 packages built:
  • libretrack
  • libretrack.debug
  • libretrack.pubcache

aarch64-linux

✅ 3 packages built:
  • libretrack
  • libretrack.debug
  • libretrack.pubcache

GaetanLepage
GaetanLepage approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage requested a review from drupol January 22, 2025 17:49
@GaetanLepage GaetanLepage merged commit 13d1fa1 into NixOS:master Jan 22, 2025
26 of 28 checks passed
@genga898 genga898 deleted the libretrack branch January 22, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adda0 Adda0 Adda0 approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: libretrack
5 participants
@genga898 @Adda0 @GaetanLepage @drupol @wegank