-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urbackup-server: init at 2.5.33; nixos/urbackup: init module #374743
base: master
Are you sure you want to change the base?
Conversation
37ad841
to
9f4060d
Compare
Can this service not run with a dynamic user and the right capabilities, to avoid needing to allocate static IDs? See also the comment on top of ids.nix |
Apologies for missing that note on ids.nix.
Edit: It's possible to use |
What do they need that's preventing them from working? Maybe there's a way. |
Some permissions issues by looking at the trace:
Trying to make a wrapper using systemd-run, but running into the same issue. (but weirdly disappears when using strace on it, so perhaps some setuid issues since urbackupsrv tries to to change the uid) reference
UPDATE: trying out the same logic as nixpkgs/nixos/modules/services/web-apps/photoprism.nix Lines 18 to 25 in eb39cec
seems to allow urbackupsrv to behave properly. One problem, though, is that some commands such as UPDATE 2: Since the service status and the commands for urbackupsrv are mutually exclusive, adding the same StateDirectory to the systemd-run wrapper should not cause any problem. |
e4b6eaf
to
d40cb66
Compare
1bc1b43
to
3f70faa
Compare
This PR adds in urbackup-server package and NixOS module.
the urbackup-server package applies a workaround for allowing the generation of keys & using state directory (since it's set at compile time).
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.