-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/types: add types.pathNotInStore
#373287
base: master
Are you sure you want to change the base?
Conversation
Seems like a good idea, although the idea seems similar to an earlier PR. Maybe @infinisil knows the status of that? I think you'll want I think in many cases, users of the type will want not just path strings, but absolute path strings.
I'd like a more compositional style (e.g. set-like operations on types), but I'm not sure that it's actually nicer for users. Probably the type |
This option parallels our existing `types.pathInStore` type. This is useful for when a module needs a path to a file, and wants to protect people from accidentally leaking that file into the nix store.
c377630
to
db879dc
Compare
Fair, changed.
Yeah, you'll see I am checking if the first character is a
I like that. Happy to implement that, but first I'll wait to hear back from @infinisil about the status of the earlier PR you referenced. |
@infinisil, not urgent, but quick ping on this PR. |
This option parallels our existing
types.pathInStore
type. This isuseful for when a module needs a path to a file, and wants to protect
people from accidentally leaking that file into the nix store.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.