-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home-assistant-custom-components.frigate: 5.3.0 -> 5.6.0 #371866
base: master
Are you sure you want to change the base?
home-assistant-custom-components.frigate: 5.3.0 -> 5.6.0 #371866
Conversation
src = fetchFromGitHub { | ||
owner = "dermotduffy"; | ||
repo = "hass-web-proxy-lib"; | ||
rev = "f96dfdec6e24275dc83b462a3471d89509f3d42a"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI not versioned on github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're super interested in running the test suite, given that we relax requirement pins fairly often, and it's best to have some code to run, so that we notice when something breaks at runtime.
}; | ||
|
||
build-system = [ poetry-core ]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried enabling the test suite? I think this library can only work on the same python version as home-assistant, because it requires (toPythonModule home-assistant)
as a test dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got close, but I need to create another package for pytest_homeassistant_custom_component
it seems
}: | ||
|
||
buildHomeAssistantComponent rec { | ||
owner = "blakeblackshear"; | ||
domain = "frigate"; | ||
version = "5.4.0"; | ||
version = "5.6.0"; | ||
|
||
src = fetchFromGitHub { | ||
owner = "blakeblackshear"; | ||
repo = "frigate-hass-integration"; | ||
rev = "v${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev = "v${version}"; | |
tag = "v${version}"; |
0c5fc13
to
66df946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need this package, then the reverse dependency should likely land in pkgs/server/home-assistant/python-modules/
instead, and be called from the overridden package set of home-assistant, where we have the pytest runner already available.
66df946
to
7971e36
Compare
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.