Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant-custom-components.frigate: 5.3.0 -> 5.6.0 #371866

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nealfennimore
Copy link
Member

@nealfennimore nealfennimore commented Jan 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

src = fetchFromGitHub {
owner = "dermotduffy";
repo = "hass-web-proxy-lib";
rev = "f96dfdec6e24275dc83b462a3471d89509f3d42a";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI not versioned on github

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're super interested in running the test suite, given that we relax requirement pins fairly often, and it's best to have some code to run, so that we notice when something breaks at runtime.

};

build-system = [ poetry-core ];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried enabling the test suite? I think this library can only work on the same python version as home-assistant, because it requires (toPythonModule home-assistant) as a test dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got close, but I need to create another package for pytest_homeassistant_custom_component it seems

}:

buildHomeAssistantComponent rec {
owner = "blakeblackshear";
domain = "frigate";
version = "5.4.0";
version = "5.6.0";

src = fetchFromGitHub {
owner = "blakeblackshear";
repo = "frigate-hass-integration";
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
tag = "v${version}";

@nealfennimore nealfennimore marked this pull request as draft January 18, 2025 01:51
@nealfennimore nealfennimore force-pushed the home-assistant-custom-components.frigate branch from 0c5fc13 to 66df946 Compare January 18, 2025 01:53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need this package, then the reverse dependency should likely land in pkgs/server/home-assistant/python-modules/ instead, and be called from the overridden package set of home-assistant, where we have the pytest runner already available.

@nealfennimore nealfennimore force-pushed the home-assistant-custom-components.frigate branch from 66df946 to 7971e36 Compare January 18, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants