Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package fork of the qc71_laptop package for Slimbook laptop compatibility
The difference between the package files is minimal. Beyond modifying the source, name, version and expected meta.*, also modify license to follow upstream:
del: license = licenses.gpl2Plus;
add: license = licenses.gpl2Only;
(I intend to make another PR for the
qc71_laptop
package to fix the license)This package includes the patches developed by the Slimbook manufacturer, which mainly revolve around adding support to their own systems for features such as RGB keyboard lighting control and the behaviour of a performance button that some of their models have. They have developed some application depending on this module.
Certainly limited in potential users, I hope that it is considered "enough usage" for inclusion into Nixpkgs
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageMy laptop tends to OOM on nixpkgs-review, but I'll try. Compiling 22 kernels will take a good while, though...
journalctl
shows the new features available in my Slimbook laptop, NixOS 24.11, rev: cbd8ec4Add a 👍 reaction to pull requests you find important.