Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init qc71 slimbook laptop #371848

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LucasFA
Copy link
Contributor

@LucasFA LucasFA commented Jan 7, 2025

Package fork of the qc71_laptop package for Slimbook laptop compatibility

The difference between the package files is minimal. Beyond modifying the source, name, version and expected meta.*, also modify license to follow upstream:
del: license = licenses.gpl2Plus;
add: license = licenses.gpl2Only;

(I intend to make another PR for the qc71_laptop package to fix the license)

This package includes the patches developed by the Slimbook manufacturer, which mainly revolve around adding support to their own systems for features such as RGB keyboard lighting control and the behaviour of a performance button that some of their models have. They have developed some application depending on this module.
Certainly limited in potential users, I hope that it is considered "enough usage" for inclusion into Nixpkgs

Things done

  • Built on platform(s)
    • x86_64-linux (NixOS)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    My laptop tends to OOM on nixpkgs-review, but I'll try. Compiling 22 kernels will take a good while, though...
  • Tested basic functionality of all binary files: I have compiled and loaded the module successfully in kernel versions 6_6 and 6_12, and journalctl shows the new features available in my Slimbook laptop, NixOS 24.11, rev: cbd8ec4
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 7, 2025
Package fork of the qc71_laptop package for Slimbook
laptop compatibility

The difference between the packaging files is minimal.
Beyond modifying the source, name, version and expected
meta.*, also modify license to follow upstream:

<     license = licenses.gpl2Plus;
---
>     license = licenses.gpl2Only;
@LucasFA LucasFA force-pushed the init_qc71_slimbook_laptop branch from 1c88ca5 to 21f5c11 Compare January 7, 2025 16:39
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant