-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackages: Stackage LTS 22 -> 23; ghc: 9.6.6 -> 9.8.4 #371032
Draft
sternenseemann
wants to merge
93
commits into
staging
Choose a base branch
from
haskell-updates
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,718
−10,283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properly on the sandbox of macOS.
github-actions
bot
added
6.topic: haskell
8.has: documentation
This PR adds or changes documentation
labels
Jan 5, 2025
13 tasks
This commit has been generated by maintainers/scripts/haskell/update-stackage.sh
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
Stackage LTS 23 ships 3.6 as the default version. Note that adding this attribute probably was not a great idea since it was never going to stay around consistently. Rather than repeating this situation, we should implement #190542 for pandoc, ideally getting help from e.g. the quarto maintainers. Ideally pkgs.pandoc would be the latest pandoc. WARNING: Build is completely untested, this change is mostly guesswork so that pkgs.pandoc evals again to a point where we can generate the package map for hackage2nix.
These overrides are obsolete since Stackage LTS ships these versions by default. We need to urgently remove these overrides since they are involved in packages that are exposed from `pkgs`, preventing us from generating the package map for hackage2nix.
This was an oversight when first adding GHC 9.8.1 which went unnoticed because the package set contained semaphore-compat thanks to GHC 9.6 not having it. Also, semaphore-compat is probably reinstallable.
This matches the update from Stackage LTS 22 -> 23 in 7ea7574c. Regenerate the package set with compiler: ghc-9.8.3 passed to Cabal using env \ HACKAGE2NIX=/nix/store/57ivr7wj0bzgkgvgp6i1dsz5rbihy2an-cabal2nix-unstable-2024-12-31/bin/hackage2nix \ bash ./maintainers/scripts/haskell/regenerate-hackage-packages.sh --fast since cabal2nix-unstable doesn't build yet (I assume).
Upstream has addressed the issue we've been trying to work around (darwin support). The upstream change is different and (iirc) more correct. We'll have to wait and see if any new issues crop up.
This approach no longer works as the latest version of postgresql-libpq discovers its dependencies via conditionally included dependencies. This mechanism doesn't work in nixpkgs at the moment, so we'll have to look into that. For now, we can remove the shuffling of dependencies which now causes an evaluation error since librarySystemDepends is unset.
- Upstream has decided that gi-g*k == 4.* should be replaced by dedicated gi-g*k4 packages. The latest versions of gi-adwaita and gi-gsk use these already. - gi-gtk == 4.0.12 and gi-gdk == 4.0.10 are compat packages forwarding (?) to the corresponding gi-g*k4 package. The gi_g*k_4 alias is retained for now, but should be removed eventually. WARNING: Builds are totally untested. Especiall gi-g*k may not work correctly.
github-actions
bot
added
6.topic: python
6.topic: kernel
The Linux kernel
8.has: module (update)
This PR changes an existing module in `nixos/`
6.topic: rust
6.topic: ocaml
6.topic: nodejs
6.topic: testing
Tooling for automated testing of packages and modules
6.topic: docker tools
6.topic: agda
"A dependently typed programming language / interactive theorem prover"
6.topic: java
Including JDK, tooling, other languages, other VMs
6.topic: php
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
labels
Jan 22, 2025
github-actions
bot
removed
6.topic: python
6.topic: kernel
The Linux kernel
8.has: module (update)
This PR changes an existing module in `nixos/`
6.topic: rust
6.topic: ocaml
6.topic: nodejs
6.topic: testing
Tooling for automated testing of packages and modules
6.topic: docker tools
6.topic: agda
"A dependently typed programming language / interactive theorem prover"
6.topic: java
Including JDK, tooling, other languages, other VMs
6.topic: php
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
labels
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: haskell
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: changelog
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 5001+
10.rebuild-linux: 5001+
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Merge
This PR is the regular merge of the
haskell-updates
branch intostaging
.This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. You may be able to find an up-to-date Hydra build report at cdepillabout/nix-haskell-updates-status.
We roughly aim to merge these
haskell-updates
PRs at least once every two weeks. See the @NixOS/haskell team calendar for who is currently in charge of this branch.haskellPackages Workflow Summary
Our workflow is currently described in
pkgs/development/haskell-modules/HACKING.md
.The short version is this:
haskell-updates
(normally at the beginning of a merge window).haskell-updates
intostaging
every two weeks.mergeable
job is succeeding on hydra.maintained
package is still broken at the time of merge, we will only merge if the maintainer has been pinged 7 days in advance. (If you care about a Haskell package, become a maintainer!)More information about Haskell packages in nixpkgs can be found in the nixpkgs manual.
This is the follow-up to #369373. Come to #haskell:nixos.org if you have any questions.