Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udev: substitute /usr/bin/cat in rules #370740

Merged
merged 2 commits into from
Jan 5, 2025
Merged

udev: substitute /usr/bin/cat in rules #370740

merged 2 commits into from
Jan 5, 2025

Conversation

cmm
Copy link
Member

@cmm cmm commented Jan 3, 2025

alsa-utils 1.2.13 introduced a change to a udev rules file that references /usr/bin/cat, so let's substitute that too.

avoids NixOS build failure with "/usr/bin/cat is called in udev rules but is not executable or does not exist".

@cmm
udev: substitute /usr/bin/cat in rules
cdc84fc 
Used by alsa-utils 1.2.13.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 3, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370740

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 5 packages built:
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references

@cmm cmm mentioned this pull request Jan 4, 2025
Closed
@ck3d ck3d mentioned this pull request Jan 4, 2025
Closed
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 4, 2025
@cmm
udev: "--replace" -> "--replace-quiet" in substitutions
b758495 
"--replace" is deprecated, and neither vocal new alternative is
appropriate in this case.
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 5, 2025
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 5, 2025
@ck3d ck3d merged commit 5abdde9 into NixOS:master Jan 5, 2025
25 of 29 checks passed
@cmm cmm deleted the fix/alsa-utils-udev-cat branch January 5, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shawn8901 Shawn8901 Shawn8901 approved these changes

@ck3d ck3d ck3d approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmm @lucasew @Shawn8901 @ck3d @wegank