Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freerdp3: 3.9.0 -> 3.10.3 #369808

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

DCsunset
Copy link
Member

@DCsunset DCsunset commented Dec 31, 2024

Diff: FreeRDP/FreeRDP@3.9.0...3.10.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Jan 1, 2025

nixpkgs-review https://github.com/lucasew/nixcfg/actions/runs/12565659821

I'd also run nixosTests.xrdp to test it as it uses freerdp as the client to test but the test uses pkgs.freerdp instead of pkgs.freerdp3 so it would not test this code.

@DCsunset
Copy link
Member Author

DCsunset commented Jan 7, 2025

The errors in the nixpkgs-review seem related to remmina only. Freerdp3 can be built successfully.

@SuperSandro2000
Copy link
Member

The errors in the nixpkgs-review seem related to remmina only. Freerdp3 can be built successfully.

Remmina is one of the main consumers of freerdp3. If it doesn't build, we shouldn't merge this PR.

@DCsunset DCsunset changed the title freerdp3: 3.9.0 -> 3.10.2 freerdp3: 3.9.0 -> 3.10.3 Jan 13, 2025
@DCsunset
Copy link
Member Author

The errors in the nixpkgs-review seem related to remmina only. Freerdp3 can be built successfully.

Remmina is one of the main consumers of freerdp3. If it doesn't build, we shouldn't merge this PR.

Is there a way to verify that the error is caused by this PR?

Based on the log, it seems that the error is a compiling error in remmina source code rather than a linking error, which may have existed before this PR.
I don't have a darwin machine so not sure how to verify it.

@nix-owners nix-owners bot requested a review from peterhoeg January 13, 2025 22:23
@SuperSandro2000
Copy link
Member

I don't have a darwin machine so not sure how to verify it.

You should have mentioned that earlier. I thought we where talking about linux. Darwin is failing for a longer time.

@SuperSandro2000
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369808


x86_64-linux

✅ 11 packages built:
  • budgie-control-center
  • budgie-control-center.debug
  • freerdp3
  • gnome-connections
  • gnome-control-center
  • gnome-control-center.debug
  • gnome-remote-desktop
  • gtk-frdp
  • phosh
  • phosh-mobile-settings
  • remmina

@SuperSandro2000 SuperSandro2000 merged commit a4599c4 into NixOS:master Jan 14, 2025
40 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants