-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freerdp3: 3.9.0 -> 3.10.3 #369808
freerdp3: 3.9.0 -> 3.10.3 #369808
Conversation
nixpkgs-review https://github.com/lucasew/nixcfg/actions/runs/12565659821 I'd also run nixosTests.xrdp to test it as it uses freerdp as the client to test but the test uses |
The errors in the nixpkgs-review seem related to remmina only. Freerdp3 can be built successfully. |
Remmina is one of the main consumers of freerdp3. If it doesn't build, we shouldn't merge this PR. |
b123dc4
to
30ad211
Compare
Is there a way to verify that the error is caused by this PR? Based on the log, it seems that the error is a compiling error in remmina source code rather than a linking error, which may have existed before this PR. |
You should have mentioned that earlier. I thought we where talking about linux. Darwin is failing for a longer time. |
|
Diff: FreeRDP/FreeRDP@3.9.0...3.10.3
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.