-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
powerstation: init at 0.4.2 #367781
powerstation: init at 0.4.2 #367781
Conversation
options.services.powerstation = { | ||
enable = lib.mkEnableOption "PowerStation"; | ||
package = lib.mkPackageOption pkgs "powerstation" { }; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a UI for this already or is the user expected to set dbus stuff manually/scripted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, OpenGamepadUI (which I am also working on packaging for NixOS) provides a UI for both PowerStation and InputPlumber. Both tools are UI agnostic though, so can be used via cli, scripting, or another user interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened a PR for the OpenGamepadUI derivation here: #368017
236c815
to
bcc3b85
Compare
bcc3b85
to
b935aab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module addition should be in a separate commit.
The commit messages should be like this:
- powerstation: init at 0.4.1
- nixos/powerstation: init
See https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions
b935aab
to
27bd20f
Compare
aarch64-linux failed when building ryzenadj. diff --git a/pkgs/by-name/po/powerstation/package.nix b/pkgs/by-name/po/powerstation/package.nix
index f24da86884f1..b0a308c90120 100644
--- a/pkgs/by-name/po/powerstation/package.nix
+++ b/pkgs/by-name/po/powerstation/package.nix
@@ -5,6 +5,7 @@
pkg-config,
udev,
pciutils,
+ ryzenadj,
cmake,
}:
@@ -31,8 +32,12 @@ rustPlatform.buildRustPackage rec {
buildInputs = [
udev
pciutils
+ ryzenadj
];
+ # use our ryzenadj library
+ env.DOCS_RS = "1";
+
postInstall = ''
cp -r rootfs/usr/* $out/
''; But unfortunately the vendored copy is at 0.15, whilst our package is at 0.16, so it doesn't work. |
I haven't done testing on ARM, so it might not be suitable for that platform, yet. Ryzenadj itself is really only useful on AMD iGPU hardware which is exclusively x86_64, so I may update PowerStation so this dependency is conditional based on the CPU architecture. |
27bd20f
to
9b66c70
Compare
PowerStation v0.4.2 should correctly build for ARM now |
9b66c70
to
daaab4b
Compare
Description of changes
Adds a derivation to run PowerStation on NixOS.
PowerStation is an open source TDP (Thermal Design Power) control and performance daemon with DBus interface. It can allow a user to control the TDP of integrated GPUs (typically for handheld gaming PCs like the ROG Ally and Legion Go) and enable/disable CPU cores to greatly extend battery life at the cost of some gaming performance.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.