Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cura-appimage: init at 5.9.0 #367409

Closed
wants to merge 1 commit into from
Closed

cura-appimage: init at 5.9.0 #367409

wants to merge 1 commit into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 22, 2024

Current Cura is difficult to build (see #186570), so in the meantime we're providing an AppImage version as well so people at least have some Cura version available.

Adapted from
#186570 (comment)
and the subsequent discussion.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Current Cura is difficult to build (see NixOS#186570), so in the meantime
we're providing an AppImage version as well so people at least have
some Cura version available.

Adapted from
  NixOS#186570 (comment)
and the subsequent discussion.
@nh2 nh2 self-assigned this Dec 22, 2024
@nh2 nh2 mentioned this pull request Dec 22, 2024
2 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 22, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 23, 2024
@FliegendeWurst
Copy link
Member

You can add me to the maintainer list. I tried the package and it works.

@bct
Copy link
Contributor

bct commented Dec 25, 2024

Happy to be a maintainer.

@pbek
Copy link
Contributor

pbek commented Dec 28, 2024

The package worked for me. Thank you, @nh2!. 👍️

Attribute pkgs.cura-appimage is a new top-level package using pkgs.callPackage ./pkgs/applications/misc/cura/appimage.nix { /* ... */ }.
Please define it in pkgs/by-name/cu/cura-appimage/package.nix instead.

But it needs to be moved...

@pbek pbek mentioned this pull request Jan 10, 2025
13 tasks
@pbek
Copy link
Contributor

pbek commented Jan 10, 2025

#372614
I create a new PR (because there was no response anymore), matched the by-name path and added the desktop icon.

@pbek
Copy link
Contributor

pbek commented Jan 10, 2025

I'll close this one meanwhile...

@pbek pbek closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants