Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/xen: declarative libxenlight, part I #363388

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

nixos/xen: declarative libxenlight, part I #363388

wants to merge 6 commits into from
+903 −878

Conversation

SigmaSquadron
Copy link
Contributor

@SigmaSquadron SigmaSquadron commented Dec 8, 2024 •
edited
Loading

  • Splits up the Xen module into smaller files.
  • Makes the oxenstored configuration compliant with RFC 0042.
  • Creates the xl format generator.
  • Makes /etc/xl.conf configurable.

No guest stuff yet. That's part II.

I would like to apologise in advance to whoever reviews formats.nix.

Things done

  • Built on platform(s)
    • x86_64-linux
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: xen-project The Xen Project hypervisor labels Dec 8, 2024
@SigmaSquadron SigmaSquadron requested review from a team, hehongbo and CertainLach December 8, 2024 22:34
@nix-owners nix-owners bot requested a review from infinisil December 8, 2024 22:35
@SigmaSquadron SigmaSquadron mentioned this pull request Dec 8, 2024
Draft
5 tasks
@SigmaSquadron SigmaSquadron force-pushed the push-qstqowzsmurr branch 2 times, most recently from edcc253 to fc8e8b2 Compare December 9, 2024 19:17
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@SigmaSquadron SigmaSquadron removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 11, 2024
@SigmaSquadron SigmaSquadron force-pushed the push-qstqowzsmurr branch 2 times, most recently from a901dca to 7dc40de Compare December 11, 2024 01:24
@SigmaSquadron
Copy link
Contributor Author

SigmaSquadron commented Dec 11, 2024 •
edited
Loading

Commits have been fixed. (praise be jj) It should now be much easier to review commit by commit.

@SigmaSquadron SigmaSquadron added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 11, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2144

@SigmaSquadron SigmaSquadron force-pushed the push-qstqowzsmurr branch 2 times, most recently from aa643cc to 0d37391 Compare December 30, 2024 19:24
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jan 17, 2025
@nix-owners nix-owners bot requested review from h7x4 and Stunkymonkey January 20, 2025 21:46
@SigmaSquadron SigmaSquadron removed the 8.has: module (new) This PR adds a module in `nixos/` label Jan 20, 2025
Stunkymonkey
Stunkymonkey requested changes Jan 20, 2025
View reviewed changes
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
@SigmaSquadron
Copy link
Contributor Author

SigmaSquadron commented Jan 20, 2025 •
edited
Loading

Something is wrong with the CI, and I'm not entirely sure why. The manual fails because it tries to connect to the internet for some reason, and I got emails about various CI checks being skipped.

Error
An unexpected error has occurred and we've been automatically notified. Errors are sometimes temporary, so please try again.

@SigmaSquadron
nixos/xen: move Xen-related files to the xen/ subdirectory
b14d16e 
Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron
nixos/xen: Separate the Xen Store options from the main Xen module
65c28a2 
Also turns the oxenstored configuration compliant with RFC 0042.

Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron
nixos/xen: Separate the EFI module from the main Xen module
a308ee4 
Also adds a warning for Lanzaboote users.

Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron
nixos/xen: simplify main module
b5b0825 
- Deduplicates the removed options functions
- Inherits everything from the top-level `lib`.
- Clarifies that the maintainers are the xen team members, not just `members`.
- Removes some superfluous newlines

Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron
formats.xenLight: init
e1ea7c7 
Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron
nixos/xen: init Domain 0 xl configuration module
977f1e1 
Signed-off-by: Fernando Rodrigues <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CertainLach CertainLach Awaiting requested review from CertainLach CertainLach was automatically assigned from NixOS/xen-project

@infinisil infinisil Awaiting requested review from infinisil

@h7x4 h7x4 Awaiting requested review from h7x4

@hsjobeki hsjobeki Awaiting requested review from hsjobeki

@GetPsyched GetPsyched Awaiting requested review from GetPsyched

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

@Stunkymonkey Stunkymonkey Awaiting requested review from Stunkymonkey

@hehongbo hehongbo Awaiting requested review from hehongbo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: xen-project The Xen Project hypervisor 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SigmaSquadron @nixos-discourse @hehongbo @Stunkymonkey @wegank @h7x4