Netgen: init at 6.2.2405 #355445
Closed
Netgen: init at 6.2.2405 #355445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: lib
qbisi
force-pushed
the
netgen
branch
2 times, most recently
from
23773ac to
96dfa27
Compare
ofborg
bot
added
11.by: package-maintainer
qbisi
force-pushed
the
netgen
branch
2 times, most recently
from
c0360b9 to
c3f404c
Compare
ofborg
bot
added
10.rebuild-darwin: 0
NickCao
reviewed
Nov 15, 2024
| --- a/cmake/generate_version_file.cmake | ||
| +++ b/cmake/generate_version_file.cmake | ||
| @@ -5,7 +5,7 @@ endif() | ||
| if(NETGEN_VERSION_GIT) |
There was a problem hiding this comment.
Can't we simply set NETGEN_VERSION_GIT in cmake flags?
Comment on lines
+103
to
+104
| # create dummy catch2 target and use system catch2 | ||
| echo "add_custom_target(project_catch)" > cmake/external_projects/catch.cmake |
There was a problem hiding this comment.
We should also make this a patch.
Comment on lines
+143
to
+144
| (lib.cmakeBool "BUILD_TESTING" finalAttrs.finalPackage.doInstallCheck) | ||
| (lib.cmakeBool "ENABLE_UNIT_TESTS" finalAttrs.finalPackage.doInstallCheck) |
There was a problem hiding this comment.
Suggested change
| (lib.cmakeBool "BUILD_TESTING" finalAttrs.finalPackage.doInstallCheck) | |
| (lib.cmakeBool "ENABLE_UNIT_TESTS" finalAttrs.finalPackage.doInstallCheck) | |
| (lib.cmakeBool "BUILD_TESTING" finalAttrs.finalPackage.doCheck) | |
| (lib.cmakeBool "ENABLE_UNIT_TESTS" finalAttrs.finalPackage.doCheck) |
Unit tests are not installCheck?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.