yubico-authenticator: rename yubioath-flutter #291584
Draft
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoriguchi
force-pushed
the
yubico-authenticator
branch
from
afc7e42 to
e9294be
Compare
ofborg
bot
added
8.has: clean-up
8.has: package (new)
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
reviewed
Feb 29, 2024
| yubioath-flutter = callPackage ../applications/misc/yubioath-flutter { }; | ||
| yubico-authenticator = callPackage ../applications/misc/yubico-authenticator { }; |
There was a problem hiding this comment.
Unfortunately CI isn't smart enough to know that this isn't a new package, and as such now requires moving it to pkgs/by-name
There was a problem hiding this comment.
So I can just ignore that error?
There was a problem hiding this comment.
I'd prefer it be moved to pkgs/by-name, CI shouldn't be red
There was a problem hiding this comment.
Okay, will do once #291598 is merged.
|
I'm waiting to open it as review once #291598 is merged, since it would need a rebase if this gets merged first. |
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The name of the application is
Yubico Authenticator, the current name makes it hard to find.https://www.yubico.com/products/yubico-authenticator
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.