Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4l2-to-ndi: init at 0-unstable-2022-09-14 #279586

Merged
merged 2 commits into from
Dec 18, 2024
Merged

v4l2-to-ndi: init at 0-unstable-2022-09-14 #279586

merged 2 commits into from
Dec 18, 2024

Conversation

pinpox
Copy link
Member

@pinpox pinpox commented Jan 8, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pinpox pinpox mentioned this pull request Jan 8, 2024
Merged
13 tasks
@Aleksanaa
Copy link
Member

Sorry for closing, CI not passing and without proper fix for a long time. If you want to work on this again, you can reopen it.

@Aleksanaa Aleksanaa closed this Oct 27, 2024
@pinpox
Copy link
Member Author

pinpox commented Oct 29, 2024

@Aleksanaa Sorry, kinda forgot about this one. It seems to only be a simple fix though, so I just pushed a commit to fix it. If that was the only thing missing, I'd still be interested in having this in nixpkgs since I might use it in the future.

@pinpox pinpox reopened this Oct 29, 2024
@pinpox pinpox marked this pull request as ready for review October 29, 2024 09:32
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 29, 2024
@ofborg ofborg bot requested a review from MayNiklas October 29, 2024 12:20
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 29, 2024
FliegendeWurst
FliegendeWurst requested changes Nov 9, 2024
View reviewed changes
pkgs/by-name/v4/v4l2-to-ndi/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/v4/v4l2-to-ndi/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/v4/v4l2-to-ndi/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/v4/v4l2-to-ndi/package.nix Outdated Show resolved Hide resolved
@pinpox pinpox force-pushed the init-v4l2-to-ndi branch 3 times, most recently from 00eb1ff to 37e655f Compare November 11, 2024 10:25
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust 6.topic: policy discussion 6.topic: vim 6.topic: vscode 6.topic: lib The Nixpkgs function library 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: dotnet Language: .NET labels Nov 11, 2024
@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust 6.topic: policy discussion 6.topic: vim 6.topic: vscode 6.topic: lib The Nixpkgs function library 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: dotnet Language: .NET 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Nov 11, 2024
@pinpox
Copy link
Member Author

pinpox commented Nov 11, 2024

@FliegendeWurst applied suggestions, rebuilds fine. Also formatted and squashed

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
@FliegendeWurst FliegendeWurst changed the title v4l2-to-ndi: init at unstable-2022-09-14 v4l2-to-ndi: init at 0-unstable-2022-09-14 Dec 18, 2024
@FliegendeWurst FliegendeWurst merged commit 48266de into NixOS:master Dec 18, 2024
37 checks passed
doronbehar pushed a commit to unclechu/nixpkgs that referenced this pull request Dec 22, 2024
@pinpox @FliegendeWurst @doronbehar
v4l2-to-ndi: init at 0-unstable-2022-09-14 (NixOS#279586)
8453924 
* v4l2-to-ndi: init at 0-unstable-2022-09-14

* Update pkgs/by-name/v4/v4l2-to-ndi/package.nix

Co-authored-by: Arne Keller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@MayNiklas MayNiklas Awaiting requested review from MayNiklas

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pinpox @Aleksanaa @FliegendeWurst @wegank