Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.@mockoon/cli: init at 4.1.0 #252081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nodePackages.@mockoon/cli: init at 4.1.0 #252081

wants to merge 1 commit into from

Conversation

eigengrau
Copy link
Contributor

Description of changes

This adds mockoon-cli, the CLI complement to mockoon.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@eigengrau
Copy link
Contributor Author

eigengrau commented Aug 29, 2023 •
edited
Loading

node-packages.nix is currently conflicted due to having been generated on a previous state of master. How do we usually handle MRs for nodePackages? I could run generate.sh again, but it might be out of date with master again by the time someone can look at the MR and merge it. Given the very long time it takes to run it I’d like to avoid running it redundantly.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 29, 2023
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 29, 2023
@ofborg ofborg bot requested a review from Luflosi August 29, 2023 07:56
dotlambda
dotlambda requested changes Sep 10, 2023
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use buildNpmPackage. See #229475.

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@ghost ghost closed this Dec 18, 2024
@ghost ghost reopened this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@Luflosi Luflosi Awaiting requested review from Luflosi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nodejs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eigengrau @dotlambda @wegank